Code review comment for lp:~lukasz-czyzykowski/django-configglue/django-1.4

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

l. 515,581: this should probably be at the start of the setUp method
l. 551,562: instead you could use the addCleanup idiom which is nicer than having to store this
l. 573,693: why mixing stdout and stderr?
l. 989: remove commented out code

Also tests are currently not passing when running them like 'python setup.py test'. I have django 1.4.1 as a system package. If tests require a specific django version (like 1.4.5, it should be specified in setup.py).

review: Needs Fixing

« Back to merge proposal