Unity 8

Code review comment for lp:~lukas-kde/unity8/unsnap-from-panel

  1. unsnap-from-panel
  2. Merge into trunk
Revision history for this message
Michał Sawicz (saviq) wrote :

The touch version of test_dragPanelToRestoreMaximizedWindow fails for me here 100% after having installled silo 2555 and lp:~ci-train-bot/unity8/unity8-ubuntu-zesty-2555:

$ sh ./builddir/tests/scripts/testShell.sh Shell::test_dragPanelToRestoreMaximizedWindow
[...]

QINFO : qmltestrunner::Shell::test_dragPanelToRestoreMaximizedWindow(with touch) toplevelwindowmodel: setFocusedWindow(Window[0x558eb3eaa7f0, id=1, MirSurface[0x558eb37ab290,"Unity 8 Mock Dashs window title"]])
FAIL! : qmltestrunner::Shell::test_dragPanelToRestoreMaximizedWindow(with touch) property state
   Actual (): maximized
   Expected (): restored
   Loc: [/home/michal/dev/canonical/unity8/repo/tests/qmltests/tst_Shell.qml(2553)]

review: Needs Fixing

« Back to merge proposal