Code review comment for lp:~lukas-kde/unity8/unsnap-from-panel

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> Two minor things in the tests:
>
> + mouseMove(panel, panel.width/2, panel.panelHeight/2, 200 /* delay */); // to
> reveal the menus
> Maybe we can add a try compare here to actaully check the menu is shown here?

Done, removed the delay

> + // start dialer, maximize it
>
> You're not starting the dialer, s/dialer/app ?

Yup fixed. Originally it was dialer but then I realized dialer-app has some special treatment in shell, such as it wouldn't show the call hint in the panel.

« Back to merge proposal