Code review comment for lp:~lukas-kde/unity8/superKeyPressFix

Revision history for this message
Albert Astals Cid (aacid) wrote :

I don't see how this makes a difference

Previously we had single shot, which means the timeout signal gets emitted and then it stops itself, so basically we get emitActivatedIfNoTouchesAround called once.

Now we have no single show but we still stop the timer when emitActivatedIfNoTouchesAround gets called, which is only from the timeout signal of the timer.

So basically the same is happening before and after the patch?

review: Needs Information

« Back to merge proposal