Code review comment for lp:~lukas-kde/unity8/newWindowDecosAndPanel

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

In test_tappingOnDecorationFocusesApplication

Please keep launching 3 applications. It's important that neither the "from" nor the "to" applications are focused before the test. That's why a 3rd one is being launched.

I guess the problem is that camera-app is now fullscreen in DesktopStage. So just replace it with another an application that is not fullscreen, like gmail-webapp.

You will have to change its saved mock geometry so that it doesn't overlap unity8-dash or dialer-app.

So just replace camera-app and gallery-app below with other two non-fullscreen apps:

"""
        WindowStateStorage.geometry = {
            'unity8-dash': Qt.rect(0, units.gu(3), units.gu(50), units.gu(40)),
            'dialer-app': Qt.rect(units.gu(51), units.gu(3), units.gu(50), units.gu(40)),
            'camera-app': Qt.rect(0, units.gu(44), units.gu(50), units.gu(40)),
            'gallery-app': Qt.rect(units.gu(51), units.gu(44), units.gu(50), units.gu(40))
        }
"""

I suggest gmail-webapp and twitter-webapp

review: Needs Fixing

« Back to merge proposal