Code review comment for lp:~lukas-kde/unity8/fix-window-buttons-touch

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> Looks good :)
>
> Some minor things
>
> Why did you remove
> menuBackend.modelData = appMenuData.generateTestData(5,5,2,3, "menu")
> from init() in the test?

It's in every method anyway

> Are the compare -> tryCompare still needed now that we don't have a timer
> anymore?

OK, fixed

> Can
> readonly property bool moving: priv.moving
> be an alias?

Nope, it doesn't work due to the "priv" declaration:

property QtObject priv: QtObject {}

« Back to merge proposal