Code review comment for lp:~lukas-kde/unity8/fix-window-buttons-touch

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good :)

Some minor things

Why did you remove
   menuBackend.modelData = appMenuData.generateTestData(5,5,2,3, "menu")
from init() in the test?

Are the compare -> tryCompare still needed now that we don't have a timer anymore?

Can
  readonly property bool moving: priv.moving
be an alias?

review: Needs Information

« Back to merge proposal