Code review comment for lp:~lukas-kde/unity8/eatDecorationMouseEvents

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Imagine the replacement of all stages with a single, new, one that mzanetti is working on. With this branch, there's yet another test he has to juggle around and mind about. But it's unnecessary as the test is not about stages code. It's a DecoratedWindow internal detail he shouldn't bother about when refactoring stages code.

It would make our qmltests code base more modular if this was moved to a tst_DecoratedWindow or a tst_WindowDecoration (ie, having it as, or closer to being, a unit test). Unless you think it's interesting to also exercise surrounding code along with it (ie, as a integration test). But following this rationale we could just as well move it to tst_OrientedShell...

In short: I believe this test looks more like (as is best as) a unit test then a integration test

« Back to merge proposal