Code review comment for lp:~lukas-kde/unity8/dynamicLauncherIcons

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I'm still not a big fan of generally disabling the cache, but ok... it seems to be required in order to reload the picture and everything else (e.g. a Loader around the shape or similar) actually seems overkill too for the fact that we only have a limited number of items in the launcher.

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

yes

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

« Back to merge proposal