Unity 8

Code review comment for lp:~lukas-kde/unity8/doubleTapToMaximize

  1. doubleTapToMaximize
  2. Merge into trunk
Revision history for this message
Michael Zanetti (mzanetti) wrote :

I really dislike that MoveHandler does all this random stuff on "target" without there being any sort of defined API in between. This needs refactoring at some point.

I think we need to define a WindowDelegate component with a proper API on all the things that the MoveHandler and DecoratedWindow access. So that we can also supply mocked WindowDelegates to tests etc (DecoratedWindow tests spit an infinite amount of warnings atm).

That said, I think this fix is still OK for now.

review: Approve

« Back to merge proposal