Code review comment for lp:~lukas-kde/unity8/activateWindows

Quite an improvement, yes! Still some small ones.

* minimize a maximized window, select it in the spread => expected: maximized, actual: restored. Same for closing a maximized one and reopening. Not sure how far we want to go with those in a single branch... this one improves things already a lot and there's still lots to do. So you decide when you want to give it a rest with this branch. We can start splitting things into multiple branches.

* managed to break alt+f4 again. I tried to log out and in again and break it again but didn't manage so far. Will keep on trying.

* During the above, I found a super weird one :D Minimize all windows, now ctrl+meta+arrow shouldn't do anything any more. Here's how: press and hold ctrl+meta and then press all 4 arrows dogether down two times in a row. It will restore a window :D Not that this would be a common thing to do, but it does indicate some focus issue when everything is minimized. Can you try to find out what's going on?

- ApplicationManager.requestFocusApplication(appId)
+ ApplicationManager.focusApplication(appId);

careful with that... can you explain the reason for this? The difference is that with "requestFocusApplication()" the shell can still execute logic like focus stealing revention (if we had that) or playing some focusing animations. If you change it to focusApplication() ApplicationManager will immediately move the item to index 0 and set it as focusedAppication. Not saying this is necessarily wrong, but just making sure you had a reason to change it.