Merge lp:~lukas-kde/qtubuntu/panelHeight into lp:qtubuntu

Proposed by Lukáš Tinkl
Status: Merged
Approved by: Gerry Boland
Approved revision: 294
Merged at revision: 299
Proposed branch: lp:~lukas-kde/qtubuntu/panelHeight
Merge into: lp:qtubuntu
Diff against target: 22 lines (+2/-3)
1 file modified
src/ubuntumirclient/window.cpp (+2/-3)
To merge this branch: bzr merge lp:~lukas-kde/qtubuntu/panelHeight
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+278718@code.launchpad.net

Commit message

Update the panel height hack, orange line is gone

Description of the change

Following the removal of the orange separator line from panel, adjust the panelHeight hack to no longer take it into account

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ubuntumirclient/window.cpp'
--- src/ubuntumirclient/window.cpp 2015-11-17 13:42:24 +0000
+++ src/ubuntumirclient/window.cpp 2015-11-26 15:45:27 +0000
@@ -215,7 +215,7 @@
215}215}
216216
217// FIXME - in order to work around https://bugs.launchpad.net/mir/+bug/1346633217// FIXME - in order to work around https://bugs.launchpad.net/mir/+bug/1346633
218// we need to guess the panel height (3GU + 2DP)218// we need to guess the panel height (3GU)
219int panelHeight()219int panelHeight()
220{220{
221 const int defaultGridUnit = 8;221 const int defaultGridUnit = 8;
@@ -228,8 +228,7 @@
228 gridUnit = defaultGridUnit;228 gridUnit = defaultGridUnit;
229 }229 }
230 }230 }
231 qreal densityPixelRatio = static_cast<qreal>(gridUnit) / defaultGridUnit;231 return gridUnit * 3;
232 return gridUnit * 3 + qFloor(densityPixelRatio) * 2;
233}232}
234233
235} //namespace234} //namespace

Subscribers

People subscribed via source and target branches