Code review comment for lp:~lukas-kde/qtmir/defaultKeymap

Revision history for this message
Gerry Boland (gerboland) wrote :

Ok, much improved, thank you.

But please add comments explaining the thread situation. We remember it now, but someone else won't have a clue, and could introduce subtle errors if they forget the locking, or remove the DirectConnection specifier thinking it extraneous.

review: Needs Fixing

« Back to merge proposal