Code review comment for lp:~lukas-kde/qtmir/defaultKeymap

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> > > In src/platforms/mirserver/mirsingleton.h:
> > >
> > > """
> > > Q_PROPERTY(QString currentKeymap READ currentKeymap WRITE setCurrentKeymap
> > > NOTIFY currentKeymapChanged)
> > > """
> > >
> > > This has to go into unity/shell/application/Mir.h interface from unity-
> api.
> >
> > Yup, I can definitely move it over there if you insist but isn't this too
> > implementation specific?
>
> If unity8 uses it, it has to be in unity-api. That's the whole point of unity-
> api: define/expose the API that unity8 uses from qtmir.

Yeah done; see also https://code.launchpad.net/~lukas-kde/unity-api/defaultKeymap/+merge/307309

« Back to merge proposal