Code review comment for lp:~lukas-kde/qtmir/defaultKeymap

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> In src/platforms/mirserver/mirsingleton.h:
>
> """
> Q_PROPERTY(QString currentKeymap READ currentKeymap WRITE setCurrentKeymap
> NOTIFY currentKeymapChanged)
> """
>
> This has to go into unity/shell/application/Mir.h interface from unity-api.

Yup, I can definitely move it over there if you insist but isn't this too implementation specific?

« Back to merge proposal