Code review comment for lp:~lukas-kde/qtmir/defaultKeymap

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

In src/platforms/mirserver/inputdeviceobserver.h:

"""
namespace mi = mir::input;
"""

Not a fan of aliasing namespaces in headers as that will contaminate any cpp file that #includes this header. Theoretically some cpp file might already use "mi" for something else and you would cause a collision, which is exactly what namespaces are there for.

Aliasing namespaces is a decision that only implementation code should make, locally.

« Back to merge proposal