Code review comment for lp:~lucio.torre/txstatsd/distinct-plugin-fix-http

The attempt to merge lp:~lucio.torre/txstatsd/distinct-plugin-fix-http into lp:~txstatsd-dev/txstatsd/distinct-plugin failed. Below is the output from the failed tests.

./bin/start-database.sh
## Starting postgres in /mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1 ##
The files belonging to this database system will be owned by user "tarmac".
This user must also own the server process.

The database cluster will be initialized with locale C.
The default text search configuration will be set to "english".

fixing permissions on existing directory /mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1/data ... ok
creating subdirectories ... ok
selecting default max_connections ... 100
selecting default shared_buffers ... 28MB
creating configuration files ... ok
creating template1 database in /mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1/data/base/1 ... ok
initializing pg_authid ... ok
initializing dependencies ... ok
creating system views ... ok
loading system objects' descriptions ... ok
creating conversions ... ok
creating dictionaries ... ok
setting privileges on built-in objects ... ok
creating information schema ... ok
vacuuming database template1 ... ok
copying template1 to template0 ... ok
copying template1 to postgres ... ok

Success. You can now start the database server using:

    /usr/lib/postgresql/8.4/bin/postgres -D /mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1/data
or
    /usr/lib/postgresql/8.4/bin/pg_ctl -D /mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1/data -l logfile start

waiting for server to start.... done
server started
CREATE ROLE
To set your environment so psql will connect to this DB instance type:
    export PGHOST=/mnt/tarmac/cache/txstatsd/distinct-plugin/tmp/db1
## Done. ##
psql -h `pwd`/tmp/db1 -d distinct < bin/schema.sql
CREATE TABLE
CREATE TABLE
CREATE INDEX
./bin/start-redis.sh
trial distinctdb/
distinctdb.tests.test_distinct
  TestDatabaseMetricStorage
    test_connect ... [OK]
    test_create_metric_id ... [OK]
    test_find_saved_data ... [OK]
    test_get_distinct_count ... [OK]
    test_get_distinct_top_value ... [OK]
    test_load_metric_id ... [OK]
    test_save_bucket_twice ... [OK]
  TestDistinctMetricReporter
    test_configure ... [OK]
    test_get_bucket_no ... [OK]
    test_max ... [OK]
    test_reports ... [OK]
  TestDistinctResource
    test_render_count_resource ... [OK]
    test_render_top_resource ... [OK]
  TestDistinctResourceIntegration
    test_count ... [OK]
    test_top ... [OK]
  TestDistinctResourceIntegrationError
    test_count ... [OK]
  TestJSONMethodResource
    test_render_result_as_json ... [OK]
  TestPlugin
    test_factory ... [OK]
  TestRedis
    test_bucket_name ... [OK]
    test_configure ... [OK]
    test_connect ... [OK]
    test_load ... [OK]
/usr/lib/pymodules/python2.6/redis/client.py:814: DeprecationWarning: Passing 'value' and 'score' has been deprecated. Please pass via kwargs instead.
    test_usage ... [OK]
/usr/lib/pymodules/python2.6/redis/client.py:814: DeprecationWarning: Passing 'value' and 'score' has been deprecated. Please pass via kwargs instead.

-------------------------------------------------------------------------------
Ran 23 tests in 44.784s

PASSED (successes=23)
./bin/stop-redis.sh
No /usr/bin/redis-server found running; none killed.

WARNING: enabling "trust" authentication for local connections
You can change this by editing pg_hba.conf or using the -A option the
next time you run initdb.
ERROR: role "client" already exists
NOTICE: CREATE TABLE will create implicit sequence "paths_id_seq" for serial column "paths.id"
NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "paths_pkey" for table "paths"
NOTICE: CREATE TABLE / UNIQUE will create implicit index "paths_path_key" for table "paths"
make: *** [stop-redis] Error 1