Code review comment for ~lucaskanashiro/ubuntu/+source/puppet:fix-links-issue

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Lucas!

I looked for a change fixing the issue upstream. Then I realized this fixes a regression introduced by debian/patches/0017-PUP-10537-keyword-param-as-last-arg.patch. This patch was backported from upstream's 6.x and the APIs changed a lot since then.

I also screened the code for any bits that could possibly rely on the value of `links` not being set, and found no instances.

LGTM

review: Approve

« Back to merge proposal