Merge ~lucaskanashiro/ubuntu/+source/pollinate:merge_4.33-3 into ubuntu/+source/pollinate:debian/sid

Proposed by Lucas Kanashiro
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 65590824194dfad8ca8c04a147cdb0c9be1bca64
Merge reported by: Bryce Harrington
Merged at revision: 65590824194dfad8ca8c04a147cdb0c9be1bca64
Proposed branch: ~lucaskanashiro/ubuntu/+source/pollinate:merge_4.33-3
Merge into: ubuntu/+source/pollinate:debian/sid
Diff against target: 119 lines (+36/-22)
6 files modified
debian/changelog (+29/-0)
debian/control (+4/-1)
debian/patches/series (+0/-1)
debian/pollinate.default (+2/-5)
debian/pollinate.install (+1/-0)
dev/null (+0/-15)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+375755@code.launchpad.net

Description of the change

Merge version 4.33-3 from Debian. Debian maintainer didn't introduce many changes in this release, so this is a quite straightforward merge. I dropped just the debian/watch file we have in our delta (it was added in Debian), the rest remains the same:

  * d/p/replace-lsb-release.patch: removed as it's Debian specific
  * Use the Ubuntu entropy server and certificate:
    - d/pollinate.default: use entropy.ubuntu.com and its certificate
    - d/pollinate.install: install the ubuntu.entropy.com certificate
  * d/control: add breaks/replaces on pollen 4.21-1 which is when the
    check_pollen script moved out of pollen. Case #9 of package transition.
    [Can be dropped after 20.04]

It built fine in this PPA: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/focal-pollinate-merge

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

TBH I doubt this is worth the effort to merge it.
The source upload doesn't matter to us and d/watch addition isn't really important.

Well, you have done the work already, so we can as well make use of it and sponsor (if you want).

But going forward I'd ask you to require a certain minimum gain for Ubuntu in doing a merge.
I'd (personally) not have had an issue marking this "done - nothing important" without doing anything. Feel free to catch me on IRC to discuss if you want.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I thought merging a version reducing a bit the delta would worth, but as you said the gain is minimal. I'll take more care next time. Regarding the sponsoring it's fine to leave as it is and mark as done.

Thanks anyway!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is fine still, I was just saying if you have two options chose the one with more tech-debt to resolve :-) This never the less is a help as many small things sum up as well.
Thanks and sponsoring ...

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/pollinate
 * [new tag] upload/4.33-3ubuntu1 -> upload/4.33-3ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading pollinate_4.33-3ubuntu1.dsc: done.
  Uploading pollinate_4.33-3ubuntu1.debian.tar.xz: done.
  Uploading pollinate_4.33-3ubuntu1_source.buildinfo: done.
  Uploading pollinate_4.33-3ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

This has migrated to focal

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index e509c8b..f2001d3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,19 @@
1pollinate (4.33-3ubuntu1) focal; urgency=medium
2
3 * Merge with Debian unstable. Remaining changes:
4 - d/p/replace-lsb-release.patch: removed as it's Debian specific
5 - Use the Ubuntu entropy server and certificate:
6 + d/pollinate.default: use entropy.ubuntu.com and its certificate
7 + d/pollinate.install: install the ubuntu.entropy.com certificate
8 - d/control: add breaks/replaces on pollen 4.21-1 which is when the
9 check_pollen script moved out of pollen. Case #9 of package transition.
10 [Can be dropped after 20.04]
11 * Dropped:
12 - d/watch: add watch file pointing at launchpad
13 [Fixed upstream]
14
15 -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Tue, 19 Nov 2019 18:34:55 -0300
16
1pollinate (4.33-3) unstable; urgency=medium17pollinate (4.33-3) unstable; urgency=medium
218
3 * upload source package19 * upload source package
@@ -5,6 +21,19 @@ pollinate (4.33-3) unstable; urgency=medium
521
6 -- Thorsten Alteholz <debian@alteholz.de> Mon, 19 Aug 2019 22:20:00 +000022 -- Thorsten Alteholz <debian@alteholz.de> Mon, 19 Aug 2019 22:20:00 +0000
723
24pollinate (4.33-2ubuntu1) eoan; urgency=medium
25
26 * d/p/replace-lsb-release.patch: removed as it's Debian specific
27 * Use the Ubuntu entropy server and certificate:
28 - d/pollinate.default: use entropy.ubuntu.com and its certificate
29 - d/pollinate.install: install the ubuntu.entropy.com certificate
30 * d/watch: add watch file pointing at launchpad
31 * d/control: add breaks/replaces on pollen 4.21-1 which is when the
32 check_pollen script moved out of pollen. Case #9 of package transition.
33 [Can be dropped after 20.04]
34
35 -- Andreas Hasenack <andreas@canonical.com> Tue, 21 May 2019 10:42:07 -0300
36
8pollinate (4.33-2) unstable; urgency=medium37pollinate (4.33-2) unstable; urgency=medium
938
10 * debian/control: add salsa VCS URLs39 * debian/control: add salsa VCS URLs
diff --git a/debian/control b/debian/control
index 2f81f34..94c8317 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: pollinate1Source: pollinate
2Section: admin2Section: admin
3Priority: optional3Priority: optional
4Maintainer: Thorsten Alteholz <debian@alteholz.de>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Thorsten Alteholz <debian@alteholz.de>
5Build-Depends: debhelper (>= 11)6Build-Depends: debhelper (>= 11)
6Standards-Version: 4.3.07Standards-Version: 4.3.0
7Homepage: http://launchpad.net/pollinate8Homepage: http://launchpad.net/pollinate
@@ -11,6 +12,8 @@ Vcs-Git: https://salsa.debian.org/alteholz/pollinate.git
11Package: pollinate12Package: pollinate
12Architecture: all13Architecture: all
13Depends: ${misc:Depends}, curl, adduser, xxd | vim-common14Depends: ${misc:Depends}, curl, adduser, xxd | vim-common
15Breaks: pollen (<< 4.21-1)
16Replaces: pollen (<< 4.21-1)
14Description: seed the pseudo random number generator17Description: seed the pseudo random number generator
15 This client will connect to one or more Pollen (entropy-as-a-service)18 This client will connect to one or more Pollen (entropy-as-a-service)
16 servers over an (optionally) encrypted connection and retrieve a random19 servers over an (optionally) encrypted connection and retrieve a random
diff --git a/debian/patches/replace-lsb-release.patch b/debian/patches/replace-lsb-release.patch
17deleted file mode 10064420deleted file mode 100644
index 9eb7218..0000000
--- a/debian/patches/replace-lsb-release.patch
+++ /dev/null
@@ -1,15 +0,0 @@
1Description: in Debian there is no /etc/lsb-release
2Author: Thorsten Alteholz <debian@alteholz.de>
3Index: pollinate-4.33/pollinate
4===================================================================
5--- pollinate-4.33.orig/pollinate 2018-05-29 22:13:20.000000000 +0200
6+++ pollinate-4.33/pollinate 2019-02-06 16:12:12.298990019 +0100
7@@ -187,7 +187,7 @@
8 # Construct a user agent, with useful debug information
9 # Very similar to Firefox and Chrome
10
11- . /etc/lsb-release
12+ DISTRIB_DESCRIPTION="Debian `cat /etc/debian_version`"
13
14 local pkg_info="" lsb="" platform="" cpu="" up="NA" idle="NA" uptime
15 read_package_versions && pkg_info="$_RET"
diff --git a/debian/patches/series b/debian/patches/series
index f1852fe..a07d0a8 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1 @@
1check-pollen-to-pollinate.patch1check-pollen-to-pollinate.patch
2replace-lsb-release.patch
diff --git a/debian/pollinate.default b/debian/pollinate.default
index 5bec75e..6b70433 100644
--- a/debian/pollinate.default
+++ b/debian/pollinate.default
@@ -5,9 +5,6 @@ BINARY=1
5QUIET=05QUIET=0
6WAIT=106WAIT=10
7DEVICE="/dev/urandom"7DEVICE="/dev/urandom"
8#8SERVER="https://entropy.ubuntu.com/"
9# plese use this SERVER only for testing
10#SERVER="https://pollen.debian.alteholz.net/"
11SERVER="https://pollen.example.com/"
12POOL=""9POOL=""
13CURL_OPTS=""10CURL_OPTS="--cacert /etc/pollinate/entropy.ubuntu.com.pem --capath /dev/null"
diff --git a/debian/pollinate.install b/debian/pollinate.install
index 7873cdc..4f32892 100644
--- a/debian/pollinate.install
+++ b/debian/pollinate.install
@@ -1,2 +1,3 @@
1pollinate /usr/bin/1pollinate /usr/bin/
2entropy.ubuntu.com.pem /etc/pollinate/
2check_pollen /usr/lib/nagios/plugins/3check_pollen /usr/lib/nagios/plugins/

Subscribers

People subscribed via source and target branches