Merge ~lucaskanashiro/ubuntu/+source/pollinate:merge_4.33-3 into ubuntu/+source/pollinate:debian/sid

Proposed by Lucas Kanashiro
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 65590824194dfad8ca8c04a147cdb0c9be1bca64
Merge reported by: Bryce Harrington
Merged at revision: 65590824194dfad8ca8c04a147cdb0c9be1bca64
Proposed branch: ~lucaskanashiro/ubuntu/+source/pollinate:merge_4.33-3
Merge into: ubuntu/+source/pollinate:debian/sid
Diff against target: 119 lines (+36/-22)
6 files modified
debian/changelog (+29/-0)
debian/control (+4/-1)
debian/patches/series (+0/-1)
debian/pollinate.default (+2/-5)
debian/pollinate.install (+1/-0)
dev/null (+0/-15)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+375755@code.launchpad.net

Description of the change

Merge version 4.33-3 from Debian. Debian maintainer didn't introduce many changes in this release, so this is a quite straightforward merge. I dropped just the debian/watch file we have in our delta (it was added in Debian), the rest remains the same:

  * d/p/replace-lsb-release.patch: removed as it's Debian specific
  * Use the Ubuntu entropy server and certificate:
    - d/pollinate.default: use entropy.ubuntu.com and its certificate
    - d/pollinate.install: install the ubuntu.entropy.com certificate
  * d/control: add breaks/replaces on pollen 4.21-1 which is when the
    check_pollen script moved out of pollen. Case #9 of package transition.
    [Can be dropped after 20.04]

It built fine in this PPA: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/focal-pollinate-merge

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

TBH I doubt this is worth the effort to merge it.
The source upload doesn't matter to us and d/watch addition isn't really important.

Well, you have done the work already, so we can as well make use of it and sponsor (if you want).

But going forward I'd ask you to require a certain minimum gain for Ubuntu in doing a merge.
I'd (personally) not have had an issue marking this "done - nothing important" without doing anything. Feel free to catch me on IRC to discuss if you want.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I thought merging a version reducing a bit the delta would worth, but as you said the gain is minimal. I'll take more care next time. Regarding the sponsoring it's fine to leave as it is and mark as done.

Thanks anyway!

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is fine still, I was just saying if you have two options chose the one with more tech-debt to resolve :-) This never the less is a help as many small things sum up as well.
Thanks and sponsoring ...

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/pollinate
 * [new tag] upload/4.33-3ubuntu1 -> upload/4.33-3ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading pollinate_4.33-3ubuntu1.dsc: done.
  Uploading pollinate_4.33-3ubuntu1.debian.tar.xz: done.
  Uploading pollinate_4.33-3ubuntu1_source.buildinfo: done.
  Uploading pollinate_4.33-3ubuntu1_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Bryce Harrington (bryce) wrote :

This has migrated to focal

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e509c8b..f2001d3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,19 @@
6+pollinate (4.33-3ubuntu1) focal; urgency=medium
7+
8+ * Merge with Debian unstable. Remaining changes:
9+ - d/p/replace-lsb-release.patch: removed as it's Debian specific
10+ - Use the Ubuntu entropy server and certificate:
11+ + d/pollinate.default: use entropy.ubuntu.com and its certificate
12+ + d/pollinate.install: install the ubuntu.entropy.com certificate
13+ - d/control: add breaks/replaces on pollen 4.21-1 which is when the
14+ check_pollen script moved out of pollen. Case #9 of package transition.
15+ [Can be dropped after 20.04]
16+ * Dropped:
17+ - d/watch: add watch file pointing at launchpad
18+ [Fixed upstream]
19+
20+ -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Tue, 19 Nov 2019 18:34:55 -0300
21+
22 pollinate (4.33-3) unstable; urgency=medium
23
24 * upload source package
25@@ -5,6 +21,19 @@ pollinate (4.33-3) unstable; urgency=medium
26
27 -- Thorsten Alteholz <debian@alteholz.de> Mon, 19 Aug 2019 22:20:00 +0000
28
29+pollinate (4.33-2ubuntu1) eoan; urgency=medium
30+
31+ * d/p/replace-lsb-release.patch: removed as it's Debian specific
32+ * Use the Ubuntu entropy server and certificate:
33+ - d/pollinate.default: use entropy.ubuntu.com and its certificate
34+ - d/pollinate.install: install the ubuntu.entropy.com certificate
35+ * d/watch: add watch file pointing at launchpad
36+ * d/control: add breaks/replaces on pollen 4.21-1 which is when the
37+ check_pollen script moved out of pollen. Case #9 of package transition.
38+ [Can be dropped after 20.04]
39+
40+ -- Andreas Hasenack <andreas@canonical.com> Tue, 21 May 2019 10:42:07 -0300
41+
42 pollinate (4.33-2) unstable; urgency=medium
43
44 * debian/control: add salsa VCS URLs
45diff --git a/debian/control b/debian/control
46index 2f81f34..94c8317 100644
47--- a/debian/control
48+++ b/debian/control
49@@ -1,7 +1,8 @@
50 Source: pollinate
51 Section: admin
52 Priority: optional
53-Maintainer: Thorsten Alteholz <debian@alteholz.de>
54+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
55+XSBC-Original-Maintainer: Thorsten Alteholz <debian@alteholz.de>
56 Build-Depends: debhelper (>= 11)
57 Standards-Version: 4.3.0
58 Homepage: http://launchpad.net/pollinate
59@@ -11,6 +12,8 @@ Vcs-Git: https://salsa.debian.org/alteholz/pollinate.git
60 Package: pollinate
61 Architecture: all
62 Depends: ${misc:Depends}, curl, adduser, xxd | vim-common
63+Breaks: pollen (<< 4.21-1)
64+Replaces: pollen (<< 4.21-1)
65 Description: seed the pseudo random number generator
66 This client will connect to one or more Pollen (entropy-as-a-service)
67 servers over an (optionally) encrypted connection and retrieve a random
68diff --git a/debian/patches/replace-lsb-release.patch b/debian/patches/replace-lsb-release.patch
69deleted file mode 100644
70index 9eb7218..0000000
71--- a/debian/patches/replace-lsb-release.patch
72+++ /dev/null
73@@ -1,15 +0,0 @@
74-Description: in Debian there is no /etc/lsb-release
75-Author: Thorsten Alteholz <debian@alteholz.de>
76-Index: pollinate-4.33/pollinate
77-===================================================================
78---- pollinate-4.33.orig/pollinate 2018-05-29 22:13:20.000000000 +0200
79-+++ pollinate-4.33/pollinate 2019-02-06 16:12:12.298990019 +0100
80-@@ -187,7 +187,7 @@
81- # Construct a user agent, with useful debug information
82- # Very similar to Firefox and Chrome
83-
84-- . /etc/lsb-release
85-+ DISTRIB_DESCRIPTION="Debian `cat /etc/debian_version`"
86-
87- local pkg_info="" lsb="" platform="" cpu="" up="NA" idle="NA" uptime
88- read_package_versions && pkg_info="$_RET"
89diff --git a/debian/patches/series b/debian/patches/series
90index f1852fe..a07d0a8 100644
91--- a/debian/patches/series
92+++ b/debian/patches/series
93@@ -1,2 +1 @@
94 check-pollen-to-pollinate.patch
95-replace-lsb-release.patch
96diff --git a/debian/pollinate.default b/debian/pollinate.default
97index 5bec75e..6b70433 100644
98--- a/debian/pollinate.default
99+++ b/debian/pollinate.default
100@@ -5,9 +5,6 @@ BINARY=1
101 QUIET=0
102 WAIT=10
103 DEVICE="/dev/urandom"
104-#
105-# plese use this SERVER only for testing
106-#SERVER="https://pollen.debian.alteholz.net/"
107-SERVER="https://pollen.example.com/"
108+SERVER="https://entropy.ubuntu.com/"
109 POOL=""
110-CURL_OPTS=""
111+CURL_OPTS="--cacert /etc/pollinate/entropy.ubuntu.com.pem --capath /dev/null"
112diff --git a/debian/pollinate.install b/debian/pollinate.install
113index 7873cdc..4f32892 100644
114--- a/debian/pollinate.install
115+++ b/debian/pollinate.install
116@@ -1,2 +1,3 @@
117 pollinate /usr/bin/
118+entropy.ubuntu.com.pem /etc/pollinate/
119 check_pollen /usr/lib/nagios/plugins/

Subscribers

People subscribed via source and target branches