Code review comment for ~lucaskanashiro/ubuntu/+source/keepalived:sru-lp1960036

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas.

I know what happened now. I was testing with "systemctl restart nginx", but that doesn't work because the restart process happens too fast and keepalived isn't able to catch the change of state. When I used stopped and then started the process using separate commands, I could finally verify that keepalived was properly detecting the lost and regaining of quorum. Sorry about the noise.

With that out of the way, I'm happy with the MP now. I'm leaving a minor cosmetic comment on the changelog, but other than that I'm +1. Thanks.

review: Approve

« Back to merge proposal