Code review comment for ~lucaskanashiro/ubuntu/+source/heartbeat:fix-autopkgtest-regression

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the clarification.

I don't have a deep knowledge about these packages and how they interact with one another, so I'm definitely not going to block this MP if you and Rafael think this is the best way forward. I was mostly concerned about a possible use case that might break with this change; I understand that heartbeat might be used together with pacemaker, but for some reason it also Depends on resource-agents, so I thought that it could be possible to use heartbeat directly (without pacemaker) *and* still want resource-agents* to be available in the system.

In any case, the change itself is simple enough and LGTM, so if you and Rafael agree with it, I'm also +1. Thanks!

review: Approve

« Back to merge proposal