Code review comment for ~lucaskanashiro/ubuntu/+source/heartbeat:fix-autopkgtest-regression

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the extra thought on this Sergio. However, from the hearbeat description you can see that the goal is to be a messaging layer which does not mean it should provide any agent. Agents are configured via pacemaker and hearbeat can be used by pacemaker. This issue was raised because of the way the test was written.

Nevertheless, I understand your point, this might became an issue when users relying on it upgrade their system. But to convince you that this is fine, in the following MP changes are added to pacemaker to recommend resource-agents-supported:

https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/pacemaker/+git/pacemaker/+merge/402284

With that, when users upgrade their system if they have pacemaker installed the resource-agents-supported will be pulled in (by default apt install recommended packages), and the IPaddr2 will become available.

As I mentioned we are not planning to support heartbeat, so the idea is to minimize the delta and make the maintenance more straightforward for us. FWIW I discussed this with Rafael and we agreed on this solution.

Is this enough to convince you? Or do you still have any concern?

« Back to merge proposal