Merge ~lucaskanashiro/ubuntu/+source/containerd:sru-containerd-xenial into ubuntu/+source/containerd:ubuntu/xenial-devel

Proposed by Lucas Kanashiro
Status: Merged
Approved by: Lucas Kanashiro
Approved revision: bb9177659bd52882d918889142cff6622ae9bcfa
Merge reported by: Lucas Kanashiro
Merged at revision: bb9177659bd52882d918889142cff6622ae9bcfa
Proposed branch: ~lucaskanashiro/ubuntu/+source/containerd:sru-containerd-xenial
Merge into: ubuntu/+source/containerd:ubuntu/xenial-devel
Diff against target: 30 lines (+10/-1)
2 files modified
debian/changelog (+9/-0)
debian/control (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Canonical Server Pending
Review via email: mp+395232@code.launchpad.net

Description of the change

Backport fix to avoid stopping docker daemon during containerd upgrade to Xenial. It should be landed together with:

https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/docker.io/+git/docker.io/+merge/395171

PPA with the proposed package:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/containerd-upgrade-issue/+packages

DEP-8 tests are passing:

autopkgtest [11:13:44]: @@@@@@@@@@@@@@@@@@@@ summary
basic-smoke PASS

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

LGTM.

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Uploaded:

$ git push pkg upload/1.2.6-0ubuntu1_16.04.5
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.35 KiB | 1.35 MiB/s, done.
Total 9 (delta 6), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/containerd
 * [new tag] upload/1.2.6-0ubuntu1_16.04.5 -> upload/1.2.6-0ubuntu1_16.04.5
$ dput ubuntu ../containerd_1.2.6-0ubuntu1\~16.04.5_source.changes
Checking signature on .changes
gpg: ../containerd_1.2.6-0ubuntu1~16.04.5_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../containerd_1.2.6-0ubuntu1~16.04.5.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading containerd_1.2.6-0ubuntu1~16.04.5.dsc: done.
  Uploading containerd_1.2.6-0ubuntu1~16.04.5.debian.tar.xz: done.
  Uploading containerd_1.2.6-0ubuntu1~16.04.5_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Version 1.2.6-0ubuntu1~16.04.5 is already being used by the latest security update, the update was someway blocked by the archive admins but it is still in the archive and my upload got rejected. I missed it because git-ubuntu did not imported it.

I am going to import it manually and apply the same changes I proposed here on top of it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 652d5a0..3797826 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
1containerd (1.2.6-0ubuntu1~16.04.5) xenial; urgency=medium
2
3 * d/control: add a Breaks for docker.io lower than 18.09.7-0ubuntu1~16.04.7
4 (LP: #1870514). The previous versions stop the docker daemon when a
5 containerd update is performed, this Breaks statement will make sure we
6 have a newer version which has the appropriate fix.
7
8 -- Lucas Kanashiro <kanashiro@ubuntu.com> Fri, 11 Dec 2020 09:19:07 -0300
9
1containerd (1.2.6-0ubuntu1~16.04.4) xenial-security; urgency=medium10containerd (1.2.6-0ubuntu1~16.04.4) xenial-security; urgency=medium
211
3 * SECURITY UPDATE: Sensitive information disclosure12 * SECURITY UPDATE: Sensitive information disclosure
diff --git a/debian/control b/debian/control
index 79e8514..585281c 100644
--- a/debian/control
+++ b/debian/control
@@ -20,7 +20,7 @@ XS-Go-Import-Path: github.com/docker/containerd
20Package: containerd20Package: containerd
21Architecture: linux-any21Architecture: linux-any
22Depends: runc (>= 1.0.0~rc7~), ${misc:Depends}, ${shlibs:Depends}22Depends: runc (>= 1.0.0~rc7~), ${misc:Depends}, ${shlibs:Depends}
23Breaks: docker.io (<= 18.09.3~)23Breaks: docker.io (<< 18.09.7-0ubuntu1~16.04.7)
24Built-Using: ${misc:Built-Using}24Built-Using: ${misc:Built-Using}
25Description: daemon to control runC25Description: daemon to control runC
26 Containerd is a daemon to control runC, built for performance and density.26 Containerd is a daemon to control runC, built for performance and density.

Subscribers

People subscribed via source and target branches