Merge ~lucaskanashiro/ubuntu/+source/clamav:focal-merge into ubuntu/+source/clamav:debian/sid

Proposed by Lucas Kanashiro
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 82d1397aa0f52e373edbaeb51a49a8eef111c96f
Merge reported by: Christian Ehrhardt 
Merged at revision: 82d1397aa0f52e373edbaeb51a49a8eef111c96f
Proposed branch: ~lucaskanashiro/ubuntu/+source/clamav:focal-merge
Merge into: ubuntu/+source/clamav:debian/sid
Diff against target: 179 lines (+109/-1)
3 files modified
debian/NEWS.Debian (+16/-0)
debian/changelog (+91/-0)
debian/control (+2/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Canonical Server Pending
Review via email: mp+378895@code.launchpad.net

Description of the change

Merge version 0.102.2+dfsg2-2 from Debian. The entire delta we carry was dropped after merging this version. However, a small change was introduced in d/NEWS to warn users about the removal of some clamav-daemon options. We use to carry a patch to avoid a failure when those options are used, but after some discussion between the Server and Security teams we decided to drop this change now. After 20.04 we should be able to drop this small delta and then make it a sync from Debian.

Here is the PPA where build in all arches was successful:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/focal-clamav-merge-0.102.2+dfsg-1/+packages

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Perhaps "Some of clamav-daemon's options" instead of "Some clamav-daemon's options".

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

> Perhaps "Some of clamav-daemon's options" instead of "Some clamav-daemon's
> options".

Thanks for catching this, already fixed.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [√] old content match as expected
- [√] changelog entry correct version and targeted codename (I wanted to criticize until I saw it was the d/NEWS file :-) )
- [√] changelog entries correct
- [√] update-maintainer has been run

Actual changes:
- [√] debian and upstream changes look safe

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop (ack that we have to wait post 20.04)
- [√] changes forwarded upstream/debian (not needed)

New Delta:
- [√] only new delta is the NEWS entry and that looks ok

Build/Test:
- [√] build is ok
- [√] verified PPA package installs/uninstalls
- [√] a few sanity checks test fine

So far all is fine, I'm running autopkgtests now, will let you know in a bit ...

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

autopkgtest [09:33:28]: @@@@@@@@@@@@@@@@@@@@ summary
clamd PASS
client PASS
milter PASS
qemu-system-x86_64: terminating on signal 15 from pid 3309 (/usr/bin/python3)

I think you are good to go.
Please catch any of us for sponsoring once you are active and there are no last-minute changes you want to make :-)

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/clamav
 * [new tag] upload/0.102.2+dfsg-1ubuntu1 -> upload/0.102.2+dfsg-1ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading clamav_0.102.2+dfsg-1ubuntu1.dsc: done.
  Uploading clamav_0.102.2+dfsg.orig.tar.xz: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1.debian.tar.xz: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1_source.buildinfo: done.
  Uploading clamav_0.102.2+dfsg-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/NEWS.Debian b/debian/NEWS.Debian
index 5daa868..dc831d3 100644
--- a/debian/NEWS.Debian
+++ b/debian/NEWS.Debian
@@ -1,3 +1,19 @@
1clamav (0.102.2+dfsg-1ubuntu1) focal; urgency=medium
2
3 Some of clamav-daemon's options were removed by upstream for a while and from
4 now on their usage will cause a failure during the start up process of this
5 service. The following options are no longer supported:
6 - StatsHostID
7 - StatsEnabled
8 - StatsPEDisabled
9 - StatsTimeout
10 - SubmitDetectionStats
11 - DetectionStatsCountry
12 - DetectionStatsHostID
13 Make sure you are not using the options above.
14
15 -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Mon, 10 Feb 2020 13:39:26 -0300
16
1clamav (0.97.5+dfsg-1) unstable; urgency=medium17clamav (0.97.5+dfsg-1) unstable; urgency=medium
218
3 This release of clamav no longer ships signature files in clamav-base so19 This release of clamav no longer ships signature files in clamav-base so
diff --git a/debian/changelog b/debian/changelog
index cea0072..303bf2d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,20 @@
1clamav (0.102.2+dfsg-1ubuntu1) focal; urgency=medium
2
3 * Merge with Debian unstable. Remaining changes:
4 - d/NEWS.Debian: Warn users about the removal of some clamav-daemon options
5 * Dropped:
6 - clamav-daemon may fail to start due to options removed in new version
7 and manually edited configuration file. (LP #1783632)
8 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
9 add patch from Debian stretch to simply warn about removed options.
10 - Update PO files. There is no need to carry a delta for this.
11 - clamav-daemon: Correct error from ScanOnAccess option removal so that
12 setting LogFile options via DebConf works again (Closes: #950296)
13 (LP #1861497)
14 [Applied by Debian in version 0.102.1+dfsg-3]
15
16 -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Mon, 10 Feb 2020 15:35:03 -0300
17
1clamav (0.102.2+dfsg-1) unstable; urgency=medium18clamav (0.102.2+dfsg-1) unstable; urgency=medium
219
3 * Import 0.102.220 * Import 0.102.2
@@ -18,6 +35,24 @@ clamav (0.102.1+dfsg-3) unstable; urgency=medium
1835
19 -- Scott Kitterman <scott@kitterman.com> Fri, 31 Jan 2020 16:49:37 -050036 -- Scott Kitterman <scott@kitterman.com> Fri, 31 Jan 2020 16:49:37 -0500
2037
38clamav (0.102.1+dfsg-2ubuntu2) focal; urgency=medium
39
40 * d/clamav-daemon.config.in: Correct error from ScanOnAccess option
41 removal so that setting LogFile options via DebConf works again.
42 (Closes: #950296) (LP: #1860217)
43
44 -- Eric Desrochers <eric.desrochers@canonical.com> Thu, 06 Feb 2020 13:56:53 +0000
45
46clamav (0.102.1+dfsg-2ubuntu1) focal; urgency=medium
47
48 * Merge with Debian unstable. Remaining changes:
49 - clamav-daemon may fail to start due to options removed in new version
50 and manually edited configuration file. (LP #1783632)
51 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
52 add patch from Debian stretch to simply warn about removed options.
53
54 -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Wed, 22 Jan 2020 09:37:47 -0300
55
21clamav (0.102.1+dfsg-2) unstable; urgency=medium56clamav (0.102.1+dfsg-2) unstable; urgency=medium
2257
23 * Add the clamonacc binary to the clamav-daemon package.58 * Add the clamonacc binary to the clamav-daemon package.
@@ -25,6 +60,16 @@ clamav (0.102.1+dfsg-2) unstable; urgency=medium
2560
26 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Mon, 23 Dec 2019 20:54:21 +010061 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Mon, 23 Dec 2019 20:54:21 +0100
2762
63clamav (0.102.1+dfsg-1ubuntu1) focal; urgency=medium
64
65 * Merge with Debian unstable. Remaining changes:
66 - clamav-daemon may fail to start due to options removed in new version
67 and manually edited configuration file. (LP #1783632)
68 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
69 add patch from Debian stretch to simply warn about removed options.
70
71 -- Lucas Kanashiro <lucas.kanashiro@canonical.com> Thu, 05 Dec 2019 18:01:14 -0300
72
28clamav (0.102.1+dfsg-1) unstable; urgency=medium73clamav (0.102.1+dfsg-1) unstable; urgency=medium
2974
30 * Import 0.102.1 (Closes: #945265)75 * Import 0.102.1 (Closes: #945265)
@@ -36,6 +81,16 @@ clamav (0.102.1+dfsg-1) unstable; urgency=medium
3681
37 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sat, 30 Nov 2019 19:22:15 +010082 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sat, 30 Nov 2019 19:22:15 +0100
3883
84clamav (0.101.4+dfsg-1ubuntu1) eoan; urgency=low
85
86 * Merge from Debian unstable. Remaining changes:
87 - clamav-daemon may fail to start due to options removed in new version
88 and manually edited configuration file. (LP #1783632)
89 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
90 add patch from Debian stretch to simply warn about removed options.
91
92 -- Gianfranco Costamagna <locutusofborg@debian.org> Sun, 25 Aug 2019 23:25:27 +0200
93
39clamav (0.101.4+dfsg-1) unstable; urgency=medium94clamav (0.101.4+dfsg-1) unstable; urgency=medium
4095
41 * Import 0.101.496 * Import 0.101.4
@@ -47,6 +102,16 @@ clamav (0.101.4+dfsg-1) unstable; urgency=medium
47102
48 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sun, 25 Aug 2019 12:38:25 +0200103 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Sun, 25 Aug 2019 12:38:25 +0200
49104
105clamav (0.101.2+dfsg-3ubuntu1) eoan; urgency=low
106
107 * Merge from Debian unstable. Remaining changes:
108 - clamav-daemon may fail to start due to options removed in new version
109 and manually edited configuration file. (LP #1783632)
110 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
111 add patch from Debian stretch to simply warn about removed options.
112
113 -- Gianfranco Costamagna <locutusofborg@debian.org> Wed, 07 Aug 2019 08:54:47 +0200
114
50clamav (0.101.2+dfsg-3) unstable; urgency=medium115clamav (0.101.2+dfsg-3) unstable; urgency=medium
51116
52 * Cherry-pick a fix from 0.101.3 to address a vulnerability to117 * Cherry-pick a fix from 0.101.3 to address a vulnerability to
@@ -54,6 +119,16 @@ clamav (0.101.2+dfsg-3) unstable; urgency=medium
54119
55 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Tue, 06 Aug 2019 21:42:06 +0200120 -- Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Tue, 06 Aug 2019 21:42:06 +0200
56121
122clamav (0.101.2+dfsg-2ubuntu1) eoan; urgency=low
123
124 * Merge from Debian unstable. Remaining changes:
125 - clamav-daemon may fail to start due to options removed in new version
126 and manually edited configuration file. (LP #1783632)
127 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
128 add patch from Debian stretch to simply warn about removed options.
129
130 -- Gianfranco Costamagna <locutusofborg@debian.org> Sat, 03 Aug 2019 10:20:31 +0200
131
57clamav (0.101.2+dfsg-2) unstable; urgency=medium132clamav (0.101.2+dfsg-2) unstable; urgency=medium
58133
59 * Remove python from build-depends:134 * Remove python from build-depends:
@@ -63,6 +138,22 @@ clamav (0.101.2+dfsg-2) unstable; urgency=medium
63138
64 -- Scott Kitterman <scott@kitterman.com> Fri, 02 Aug 2019 09:20:43 -0400139 -- Scott Kitterman <scott@kitterman.com> Fri, 02 Aug 2019 09:20:43 -0400
65140
141clamav (0.101.2+dfsg-1ubuntu2) eoan; urgency=medium
142
143 * Rebuild against new libjson-c4.
144
145 -- Gianfranco Costamagna <locutusofborg@debian.org> Sat, 29 Jun 2019 13:48:24 +0200
146
147clamav (0.101.2+dfsg-1ubuntu1) eoan; urgency=medium
148
149 * Sync with Debian. Remaining change:
150 - clamav-daemon may fail to start due to options removed in new version
151 and manually edited configuration file. (LP #1783632)
152 + debian/patches/Deprecate-unused-options-instead-of-removing-it.patch:
153 add patch from Debian stretch to simply warn about removed options.
154
155 -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 23 Apr 2019 11:40:41 -0400
156
66clamav (0.101.2+dfsg-1) unstable; urgency=high157clamav (0.101.2+dfsg-1) unstable; urgency=high
67158
68 * Import 0.101.2159 * Import 0.101.2
diff --git a/debian/control b/debian/control
index a635cf6..1e1cd53 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: clamav1Source: clamav
2Section: utils2Section: utils
3Priority: optional3Priority: optional
4Maintainer: ClamAV Team <pkg-clamav-devel@lists.alioth.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: ClamAV Team <pkg-clamav-devel@lists.alioth.debian.org>
5Uploaders: Michael Meskes <meskes@debian.org>,6Uploaders: Michael Meskes <meskes@debian.org>,
6 Michael Tautschnig <mt@debian.org>,7 Michael Tautschnig <mt@debian.org>,
7 Scott Kitterman <scott@kitterman.com>,8 Scott Kitterman <scott@kitterman.com>,

Subscribers

People subscribed via source and target branches