Code review comment for lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension

Pedro,

I made a separate view to avoid potential conflicts (now and in the future) between the javascript code in this module and the javascript code in the standard account module.

Also the use case for the two list views is different:
- The 'account' module list view has been extended with a (imho rather primitive) technique to facilitate the encoding of journal items.
- The 'move line search all' view is intended to facilitate the search through thousands/millions of journal items.

I hope that this small module can be discontinued in V8 and that we get again a "general, V6' type of search view that allows us to configure on any object what I have hardcoded in javascipt for one particular object.
Fabien has committed that V8 will come with an improved search view, hence I am looking forward to see what it will offer.

Regards,
Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Pedro Manuel Baeza
Sent: donderdag 20 maart 2014 16:21
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension into lp:account-financial-tools

Review: Needs Information

Hi, Luc, thanks for the contribution,

It isn't better to extend current journal items view? Is there any blocking issue that prevents it?

Regards
--
https://code.launchpad.net/~luc-demeyer/account-financial-tools/add-account_move_line_search_extension/+merge/211967
You are the owner of lp:~luc-demeyer/account-financial-tools/add-account_move_line_search_extension.