Merge lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:~account-report-core-editor/account-financial-report/7.0

[Luc De Meyer (Noviat)]

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Could you take the time to bring this to the 7.0 community addons coding conventions. This includes:

* not using the shortcut imports (things in the openerp namespace need to be imported from openerp)
* using the from . import xxx for relative imports (typically in __init__.py files)
* using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory
* not instanciating the model classes
* following PEP8 for spacing, line wrapping, etc.

Nice to have would be a couple of automated tests exercising the code.

review: Needs Fixing (code review, no test)

[lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls]

56. By Luc De Meyer on 2013-10-31

technical update

[Luc De Meyer (Noviat) (luc-demeyer)]

I have updated branch https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls according to the technical recommendations.

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Alexandre Fayolle - camptocamp
Sent: donderdag 24 oktober 2013 10:13
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

Review: Needs Fixing code review, no test

Could you take the time to bring this to the 7.0 community addons coding conventions. This includes:

* not using the shortcut imports (things in the openerp namespace need to be imported from openerp)
* using the from . import xxx for relative imports (typically in __init__.py files)
* using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory
* not instanciating the model classes
* following PEP8 for spacing, line wrapping, etc.

Nice to have would be a couple of automated tests exercising the code.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Luc, when report_xls will be available on https://launchpad.net/openerp-reporting-engines, it would be desirable to have a reference to this repository on the description of the module. Something like:

"If you are installing this module manually, you need also the module 'report_xls', that is located in:

https://launchpad.net/openerp-reporting-engines"

Regards.

[Alexis de Lattre (alexis-via)]

It is definitely a great module.

But I just found a bug : if you inherit _report_xls_fields() to personnalise the list of fields and you don't put the field 'balance' in the list, then you get a crash on report generation :

Traceback (most recent call last):
  File "/home/erp_super/erp/prod/src/server/openerp/service/web_services.py", line 712, in go
    (result, format) = obj.create(cr, uid, ids, datas, context)
  File "/home/erp_super/erp/prod/src/reporting-engines/report_xls/report_xls.py", line 106, in create
    return self.create_source_xls(cr, uid, ids, data, context)
  File "/home/erp_super/erp/prod/src/reporting-engines/report_xls/report_xls.py", line 122, in create_source_xls
    self.generate_xls_report(_p, _xs, data, objs, wb)
  File "/home/erp_super/erp/prod/src/custom_scentys/test-modules/account_move_line_report_xls/report/move_line_list_xls.py", line 181, in generate_xls_report
    debit_cell = rowcol_to_cell(row_pos, debit_pos)
UnboundLocalError: local variable 'debit_pos' referenced before assignment

review: Needs Fixing (test)

[Alexis de Lattre (alexis-via)]

@Luc

I have prepared a small patch that you can find here :

http://people.via.ecp.fr/~alexis/account_move_line_report_xls-adl-enhancement.diff

It adds several fields (journal, analytic_account, company_currency, other_currency, other_currency_amount) that I've been missing in my first in real-life usage of your module. It also updates the syntax of __openerp__.py to 7.0 version. Could you review this patch and apply it in your branch ?

[Alexis de Lattre (alexis-via)]

About the crash that I mentionned 2 comments above, the reason is quite obvious when you look at the code in report/move_line_list_xls.py in the function generate_xls_report() : the variable debit_pos is declared and initialized in a block of code under :

if 'balance' in wanted_list':

and then it is used in a block of code which is executed in all cases.

[lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls]

57. By Luc De Meyer on 2013-12-18

translations, extra fields, better inheritance support

[Luc De Meyer (Noviat) (luc-demeyer)]

Alexis,

We already fixed this problems in the version that you find on our V7 "apps.openerp.com" launchpad branch, cf. ~noviat/openobject-addons/extra-7.0.
This version also extends the inherit concept to add new fields (in order to support add-on modules that add account_move_line fields and also add french and dutch translations).

I have uploaded the new version to https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Alexis de Lattre
Sent: zaterdag 14 december 2013 0:17
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

About the crash that I mentionned 2 comments above, the reason is quite obvious when you look at the code in report/move_line_list_xls.py in the function generate_xls_report() : the variable debit_pos is declared and initialized in a block of code under :

if 'balance' in wanted_list':

and then it is used in a block of code which is executed in all cases.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Luc De Meyer (Noviat) (luc-demeyer)]

Alexis,

Cf. our update on https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/ which is now synced with our version on our V7 apps.openerp.com branch.
The "other_currency, other_currency_amount" were already there.
I have added the journal, analytic_account, company_currency fields from your merge proposal.

You will also remark that the XLS template can now be customised via an inherited module hence 'account_move_line' fields added by OpenERP or Community addons can be added to the XLS export in a few minutes.

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Alexis de Lattre
Sent: vrijdag 13 december 2013 16:35
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

@Luc

I have prepared a small patch that you can find here :

http://people.via.ecp.fr/~alexis/account_move_line_report_xls-adl-enhancement.diff

It adds several fields (journal, analytic_account, company_currency, other_currency, other_currency_amount) that I've been missing in my first in real-life usage of your module. It also updates the syntax of __openerp__.py to 7.0 version. Could you review this patch and apply it in your branch ?
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Alexis de Lattre (alexis-via)]

Luc,

Thank you for taking into account my patch and fixing the bug !

review: Approve

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (code review)

[Frederic Clementi - Camptocamp (frederic-clementi)]

Is the analytical account still missing in this version ?

review: Needs Fixing (functional)

[Luc De Meyer (Noviat) (luc-demeyer)]

Analytic account is available in this version.
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Frederic Clementi - Camptocamp
Sent: maandag 6 januari 2014 12:14
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

Review: Needs Fixing functional

Is the analytical account still missing in this version ?
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Alexis de Lattre (alexis-via)]

Yes, it is available, but it is not displayed by default in the XLS report, cf the fonction _report_xls_fields().

I think that we should add 2 fields in the default report :
- analytic account
- journal code

What do you think ?

[Luc De Meyer (Noviat) (luc-demeyer)]

We have installed this module in the meanwhile at most of our customers and requirements vary from customer to customer which makes it difficult to decide upon the default fields but adding journal & analytic certainly makes sense.
If no objection, I propose to change the default as follows :

Current default :

    def _report_xls_fields(self, cr, uid, context=None):
        return [
            'move', 'name', 'date', 'period', 'partner', 'account',
            'date_maturity', 'debit', 'credit', 'balance', 'reconcile', 'reconcile_partial',
        ]

New default:

    def _report_xls_fields(self, cr, uid, context=None):
        return [
            'move', 'name', 'date', 'journal', 'period', 'partner', 'account',
            'date_maturity', 'debit', 'credit', 'balance', 'reconcile', 'reconcile_partial', 'analytic_account',
        ]

I'll also update the module documentation so that anyone understands the customisation capabilities without having to read the code.

Regards,
Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Alexis de Lattre
Sent: dinsdag 7 januari 2014 22:39
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

Yes, it is available, but it is not displayed by default in the XLS report, cf the fonction _report_xls_fields().

I think that we should add 2 fields in the default report :
- analytic account
- journal code

What do you think ?
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Alexis de Lattre (alexis-via)]

@Luc

I approve your proposal for the new list of default fields !

[Frederic Clementi - Camptocamp (frederic-clementi)]

Ok on my side

review: Approve (functional)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

review: Approve (code review, no test)

[Alexis de Lattre (alexis-via)]

@Alexandre :

Thanks for the merge... but it doesn't contain the new list of default fields we decided above in the function _report_xls_fields() in account_move_line.py. Could you update it ?

[Frederic Clementi - Camptocamp (frederic-clementi)]

@ Alexandre @ Alexis Oups Sorry my mistake. I told Alexandre it was ok.

[Frederic Clementi - Camptocamp (frederic-clementi)]

@Luc I agree with the new default list as well

[Luc De Meyer (Noviat) (luc-demeyer)]

Don't worry.
I'll make a new merge with the default fields and documentation update.

Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Alexis de Lattre
Sent: woensdag 8 januari 2014 10:21
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

@Alexandre :

Thanks for the merge... but it doesn't contain the new list of default fields we decided above in the function _report_xls_fields() in account_move_line.py. Could you update it ?
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

[Luc De Meyer (Noviat) (luc-demeyer)]

New defaults list available in
https://code.launchpad.net/~luc-demeyer/account-financial-report/update-7.0-account_move_line_report_xls/+merge/200990

Luc

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Frederic Clementi - Camptocamp
Sent: woensdag 8 januari 2014 10:51
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report

@Luc I agree with the new default list as well
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls.

=== added directory 'account_move_line_report_xls'
=== added file 'account_move_line_report_xls/__init__.py'
--- account_move_line_report_xls/__init__.py	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/__init__.py	2013-12-18 18:05:24 +0000
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import account_move_line
+from . import report

=== added file 'account_move_line_report_xls/__openerp__.py'
--- account_move_line_report_xls/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/__openerp__.py	2013-12-18 18:05:24 +0000
@@ -0,0 +1,46 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Account Move Line XLS export',
+    'version': '0.5',
+    'license': 'AGPL-3',
+    'author': 'Noviat',
+    'category' : 'Accounting & Finance',
+    'description': """
+
+Journal Items Excel Export
+==========================
+
+This module adds a button on the journal items ('account.move.line') list view in order to export the selected lines.
+
+If you are installing this module manually, you need also the module 'report_xls', that is located in:
+https://launchpad.net/openerp-reporting-engines"
+
+    """,
+    'depends': ['account', 'report_xls'],
+    'demo_xml': [],
+    'init_xml': [],
+    'update_xml' : [
+        'report/move_line_list_xls.xml',      
+    ],
+}

=== added file 'account_move_line_report_xls/account_move_line.py'
--- account_move_line_report_xls/account_move_line.py	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/account_move_line.py	2013-12-18 18:05:24 +0000
@@ -0,0 +1,52 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm
+from openerp.addons.report_xls.utils import rowcol_to_cell, _render
+from openerp.tools.translate import _
+
+class account_move_line(orm.Model):
+    _inherit = 'account.move.line'
+    
+    # override list in custom module to add/drop columns or change order
+    def _report_xls_fields(self, cr, uid, context=None):
+        return [
+            'move', 'name', 'date', 'period', 'partner', 'account',
+            'date_maturity', 'debit', 'credit', 'balance', 'reconcile', 'reconcile_partial',
+            #'amount_currency', 'currency_name',
+        ]
+        
+    # Change/Add Template entries
+    def _report_xls_template(self, cr, uid, context=None):   
+        """  
+        Template updates, e.g. 
+        
+        my_change = {
+            'move':{
+                'header': [1, 20, 'text', _('My Move Title')],
+                'lines': [1, 0, 'text', _render("line.move_id.name or ''")],
+                'totals': [1, 0, 'text', None]},
+        }
+        return my_change
+        """   
+        return {}
+

=== added directory 'account_move_line_report_xls/i18n'
=== added file 'account_move_line_report_xls/i18n/fr.po'
--- account_move_line_report_xls/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/i18n/fr.po	2013-12-18 18:05:24 +0000
@@ -0,0 +1,111 @@
+# French translation of OpenERP Server 6.1.
+# This file contains the translation of the following modules:
+#	* account_move_line_report_xls
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.1\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2013-11-23 16:11:12.706000\n"
+"PO-Revision-Date: 2013-11-23 16:11:12.706000\n"
+"Last-Translator: Luc De Meyer (Noviat nv/sa)\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Journal Items"
+msgstr "Écritures comptables"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Entry"
+msgstr "Écriture"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Name"
+msgstr "Nom"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Reference"
+msgstr "Référence"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Effective Date"
+msgstr "Date"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Period"
+msgstr "Période"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Partner"
+msgstr "Partenaire"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Partner Reference"
+msgstr "Réf. Partenaire"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Account"
+msgstr "Compte"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Maturity Date"
+msgstr "Date d'échéance"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Debit"
+msgstr "Débit"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Credit"
+msgstr "Crédit"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Balance"
+msgstr "Solde"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Rec."
+msgstr "Let."
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Part. Rec."
+msgstr "Let. Part."
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Tax Code"
+msgstr "Case TVA"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Tax/Base Amount"
+msgstr "Montant TVA/Base"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Am. Currency"
+msgstr "Montant devise"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Curr."
+msgstr "Dev."
+

=== added file 'account_move_line_report_xls/i18n/nl.po'
--- account_move_line_report_xls/i18n/nl.po	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/i18n/nl.po	2013-12-18 18:05:24 +0000
@@ -0,0 +1,111 @@
+# Dutch translation of OpenERP Server 6.1.
+# This file contains the translation of the following modules:
+#	* account_move_line_report_xls
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 6.1\n"
+"Report-Msgid-Bugs-To: [e-mail]\n"
+"POT-Creation-Date: 2013-11-23 16:11:12.702000\n"
+"PO-Revision-Date: 2013-11-23 16:11:12.702000\n"
+"Last-Translator: Luc De Meyer (Noviat nv/sa)\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Journal Items"
+msgstr "Boekingsregels"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Entry"
+msgstr "Boeking"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Name"
+msgstr "Naam"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Reference"
+msgstr "Referentie"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Effective Date"
+msgstr "Datum"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Period"
+msgstr "Periode"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Partner"
+msgstr "Partner"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Partner Reference"
+msgstr "Ref. Partner"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Account"
+msgstr "Rekening"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Maturity Date"
+msgstr "Vervaldatum"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Debit"
+msgstr "Debet"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Credit"
+msgstr "Credit"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Balance"
+msgstr "Saldo"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Rec."
+msgstr "Rec."
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Part. Rec."
+msgstr "Rec. Part."
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Tax Code"
+msgstr "BTW vak"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Tax/Base Amount"
+msgstr "Bedrag BTW/Mvh"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Am. Currency"
+msgstr "Bedrag valuta"
+
+#. module: account_move_line_report_xls
+#: report:move.line.list.xls:0
+msgid "Curr."
+msgstr "Val."
+

=== added directory 'account_move_line_report_xls/report'
=== added file 'account_move_line_report_xls/report/__init__.py'
--- account_move_line_report_xls/report/__init__.py	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/report/__init__.py	2013-12-18 18:05:24 +0000
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import move_line_list_xls

=== added file 'account_move_line_report_xls/report/move_line_list_xls.py'
--- account_move_line_report_xls/report/move_line_list_xls.py	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/report/move_line_list_xls.py	2013-12-18 18:05:24 +0000
@@ -0,0 +1,240 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import xlwt
+import time
+from datetime import datetime
+from openerp.osv import orm
+from openerp.report import report_sxw
+from openerp.addons.report_xls.report_xls import report_xls
+from openerp.addons.report_xls.utils import rowcol_to_cell, _render
+from openerp.tools.translate import translate, _
+from openerp import pooler
+import logging
+_logger = logging.getLogger(__name__)
+
+_ir_translation_name = 'move.line.list.xls'
+
+class move_line_xls_parser(report_sxw.rml_parse):
+           
+    def __init__(self, cr, uid, name, context):
+        super(move_line_xls_parser, self).__init__(cr, uid, name, context=context)
+        move_obj = self.pool.get('account.move.line')
+        self.context = context
+        wanted_list = move_obj._report_xls_fields(cr, uid, context)
+        template_changes = move_obj._report_xls_template(cr, uid, context)
+        self.localcontext.update({
+            'datetime': datetime,
+            'wanted_list': wanted_list,
+            'template_changes': template_changes,
+            '_': self._,
+        })
+
+    def _(self, src):
+        lang = self.context.get('lang', 'en_US')
+        return translate(self.cr, _ir_translation_name, 'report', lang, src) or src
+
+class move_line_xls(report_xls):
+
+    def __init__(self, name, table, rml=False, parser=False, header=True, store=False):
+        super(move_line_xls, self).__init__(name, table, rml, parser, header, store)
+
+        # Cell Styles
+        _xs = self.xls_styles        
+        # header
+        rh_cell_format = _xs['bold'] + _xs['fill'] + _xs['borders_all']
+        self.rh_cell_style = xlwt.easyxf(rh_cell_format)
+        self.rh_cell_style_center = xlwt.easyxf(rh_cell_format + _xs['center'])
+        self.rh_cell_style_right = xlwt.easyxf(rh_cell_format + _xs['right'])
+        # lines  
+        aml_cell_format = _xs['borders_all']
+        self.aml_cell_style = xlwt.easyxf(aml_cell_format)
+        self.aml_cell_style_center = xlwt.easyxf(aml_cell_format + _xs['center'])
+        self.aml_cell_style_date = xlwt.easyxf(aml_cell_format + _xs['left'], num_format_str = report_xls.date_format)
+        self.aml_cell_style_decimal = xlwt.easyxf(aml_cell_format + _xs['right'], num_format_str = report_xls.decimal_format)
+        # totals
+        rt_cell_format = _xs['bold'] + _xs['fill'] + _xs['borders_all']
+        self.rt_cell_style = xlwt.easyxf(rt_cell_format)
+        self.rt_cell_style_right = xlwt.easyxf(rt_cell_format + _xs['right'])       
+        self.rt_cell_style_decimal = xlwt.easyxf(rt_cell_format + _xs['right'], num_format_str = report_xls.decimal_format)
+        
+        # XLS Template
+        self.col_specs_template = {
+            'move':{
+                'header': [1, 20, 'text', _render("_('Entry')")],
+                'lines': [1, 0, 'text', _render("line.move_id.name or ''")],
+                'totals': [1, 0, 'text', None]},
+            'name':{      
+                'header': [1, 42, 'text', _render("_('Name')")],
+                'lines': [1, 0, 'text', _render("line.name or ''")],                
+                'totals': [1, 0, 'text', None]},
+            'ref':{      
+                'header': [1, 42, 'text', _render("_('Reference')")],
+                'lines': [1, 0, 'text', _render("line.ref or ''")],                
+                'totals': [1, 0, 'text', None]},
+            'date':{      
+                'header': [1, 13, 'text', _render("_('Effective Date')")],
+                'lines': [1, 0, 'date', _render("datetime.strptime(line.date,'%Y-%m-%d')"), None, self.aml_cell_style_date],
+                'totals': [1, 0, 'text', None]},
+            'period':{      
+                'header': [1, 12, 'text', _render("_('Period')")],
+                'lines': [1, 0, 'text', _render("line.period_id.code or line.period_id.name")],
+                'totals': [1, 0, 'text', None]},
+            'partner':{
+                'header': [1, 36, 'text', _render("_('Partner')")],
+                'lines': [1, 0, 'text', _render("line.partner_id and line.partner_id.name or ''")],
+                'totals': [1, 0, 'text', None]},
+            'partner_ref':{
+                'header': [1, 36, 'text', _render("_('Partner Reference')")],
+                'lines': [1, 0, 'text', _render("line.partner_id and line.partner_id.ref or ''")],
+                'totals': [1, 0, 'text', None]},
+            'account':{
+                'header': [1, 12, 'text', _render("_('Account')")],
+                'lines': [1, 0, 'text', _render("line.account_id.code")],
+                'totals': [1, 0, 'text', None]},
+            'date_maturity':{
+                'header': [1, 13, 'text', _render("_('Maturity Date')")],
+                'lines': [1, 0, _render("line.date_maturity.val and 'date' or 'text'"),
+                    _render("line.date_maturity.val and datetime.strptime(line.date_maturity,'%Y-%m-%d') or None"),
+                    None, self.aml_cell_style_date],
+                'totals': [1, 0, 'text', None]},
+            'debit':{
+                'header': [1, 18, 'text', _render("_('Debit')"), None, self.rh_cell_style_right],
+                'lines': [1, 0, 'number', _render("line.debit"), None, self.aml_cell_style_decimal],
+                'totals': [1, 0, 'number', None, _render("debit_formula"), self.rt_cell_style_decimal]},
+            'credit':{
+                'header': [1, 18, 'text', _render("_('Credit')"), None, self.rh_cell_style_right],
+                'lines': [1, 0, 'number', _render("line.credit"), None, self.aml_cell_style_decimal],
+                'totals': [1, 0, 'number', None, _render("credit_formula"), self.rt_cell_style_decimal]},
+            'balance':{
+                'header': [1, 18, 'text', _render("_('Balance')"), None, self.rh_cell_style_right],
+                'lines': [1, 0, 'number', None, _render("bal_formula"), self.aml_cell_style_decimal],
+                'totals': [1, 0, 'number', None, _render("bal_formula"), self.rt_cell_style_decimal]},
+            'reconcile':{
+                'header': [1, 12, 'text', _render("_('Rec.')"), None, self.rh_cell_style_center],
+                'lines': [1, 0, 'text', _render("line.reconcile_id.name or ''"), None, self.aml_cell_style_center],
+                'totals': [1, 0, 'text', None]},
+            'reconcile_partial':{
+                'header': [1, 12, 'text', _render("_('Part. Rec.')"), None, self.rh_cell_style_center],
+                'lines': [1, 0, 'text', _render("line.reconcile_partial_id.name or ''"), None, self.aml_cell_style_center],
+                'totals': [1, 0, 'text', None]},
+            'tax_code':{
+                'header': [1, 12, 'text', _render("_('Tax Code')"), None, self.rh_cell_style_center],
+                'lines': [1, 0, 'text', _render("line.tax_code_id.code or ''"), None, self.aml_cell_style_center],
+                'totals': [1, 0, 'text', None]},
+            'tax_amount':{
+                'header': [1, 18, 'text', _render("_('Tax/Base Amount')"), None, self.rh_cell_style_right],
+                'lines': [1, 0, 'number', _render("line.tax_amount"), None, self.aml_cell_style_decimal],
+                'totals': [1, 0, 'text', None]},
+            'amount_currency':{
+                'header': [1, 18, 'text', _render("_('Am. Currency')"), None, self.rh_cell_style_right],
+                'lines': [1, 0, _render("line.amount_currency and 'number' or 'text'"),
+                    _render("line.amount_currency or None"),
+                    None, self.aml_cell_style_decimal],
+                'totals': [1, 0, 'text', None]},
+            'currency_name':{
+                'header': [1, 6, 'text', _render("_('Curr.')"), None, self.rh_cell_style_center],
+                'lines': [1, 0, 'text', _render("line.currency_id and line.currency_id.name or ''"), None, self.aml_cell_style_center],
+                'totals': [1, 0, 'text', None]},
+            'journal': {
+                'header': [1, 6, 'text', _('Journal')],
+                'lines': [1, 0, 'text', _render("line.journal_id.code or ''")],
+                'totals': [1, 0, 'text', None]},
+            'company_currency': {
+                'header': [1, 6, 'text', _('Company currency')],
+                'lines': [1, 0, 'text', _render("line.company_id.currency_id.name or ''")],
+                'totals': [1, 0, 'text', None]},
+            'analytic_account': {
+                'header': [1, 6, 'text', _('Analytic Account')],
+                'lines': [1, 0, 'text', _render("line.analytic_account_id.code or ''")],
+                'totals': [1, 0, 'text', None]},       
+        }
+    
+    def generate_xls_report(self, _p, _xs, data, objects, wb):
+
+        wanted_list = _p.wanted_list
+        self.col_specs_template.update(_p.template_changes)
+        _ = _p._
+
+        debit_pos = 'debit' in wanted_list and wanted_list.index('debit')
+        credit_pos = 'credit' in wanted_list and wanted_list.index('credit')
+        if not (credit_pos and debit_pos) and 'balance' in wanted_list:
+            raise orm.except_orm(_('Customisation Error!'), 
+                _("The 'Balance' field is a calculated XLS field requiring the presence of the 'Debit' and 'Credit' fields !"))
+        
+        #report_name = objects[0]._description or objects[0]._name
+        report_name = _("Journal Items")        
+        ws = wb.add_sheet(report_name[:31])
+        ws.panes_frozen = True
+        ws.remove_splits = True
+        ws.portrait = 0 # Landscape
+        ws.fit_width_to_pages = 1
+        row_pos = 0
+        
+        # set print header/footer
+        ws.header_str = self.xls_headers['standard']
+        ws.footer_str = self.xls_footers['standard']
+
+        # Title
+        cell_style = xlwt.easyxf(_xs['xls_title'])
+        c_specs = [
+            ('report_name', 1, 0, 'text', report_name),
+        ]       
+        row_data = self.xls_row_template(c_specs, ['report_name'])
+        row_pos = self.xls_write_row(ws, row_pos, row_data, row_style=cell_style)
+        row_pos += 1
+
+        # Column headers
+        c_specs = map(lambda x: self.render(x, self.col_specs_template, 'header', render_space={'_': _p._}), wanted_list)
+        row_data = self.xls_row_template(c_specs, [x[0] for x in c_specs])
+        row_pos = self.xls_write_row(ws, row_pos, row_data, row_style=self.rh_cell_style, set_column_size=True)        
+        ws.set_horz_split_pos(row_pos)   
+        
+        # account move lines
+        for line in objects:
+            debit_cell = rowcol_to_cell(row_pos, debit_pos)
+            credit_cell = rowcol_to_cell(row_pos, credit_pos)
+            bal_formula = debit_cell + '-' + credit_cell
+            c_specs = map(lambda x: self.render(x, self.col_specs_template, 'lines'), wanted_list)
+            row_data = self.xls_row_template(c_specs, [x[0] for x in c_specs])
+            row_pos = self.xls_write_row(ws, row_pos, row_data, row_style=self.aml_cell_style)
+
+        # Totals           
+        aml_cnt = len(objects)
+        debit_start = rowcol_to_cell(row_pos - aml_cnt, debit_pos)
+        debit_stop = rowcol_to_cell(row_pos - 1, debit_pos)
+        debit_formula = 'SUM(%s:%s)' %(debit_start, debit_stop)
+        credit_start = rowcol_to_cell(row_pos - aml_cnt, credit_pos)
+        credit_stop = rowcol_to_cell(row_pos - 1, credit_pos)
+        credit_formula = 'SUM(%s:%s)' %(credit_start, credit_stop)
+        debit_cell = rowcol_to_cell(row_pos, debit_pos)
+        credit_cell = rowcol_to_cell(row_pos, credit_pos)
+        bal_formula = debit_cell + '-' + credit_cell
+        c_specs = map(lambda x: self.render(x, self.col_specs_template, 'totals'), wanted_list)
+        row_data = self.xls_row_template(c_specs, [x[0] for x in c_specs])
+        row_pos = self.xls_write_row(ws, row_pos, row_data, row_style=self.rt_cell_style_right) 
+
+move_line_xls('report.move.line.list.xls', 
+    'account.move.line',
+    parser=move_line_xls_parser)
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
\ No newline at end of file

=== added file 'account_move_line_report_xls/report/move_line_list_xls.xml'
--- account_move_line_report_xls/report/move_line_list_xls.xml	1970-01-01 00:00:00 +0000
+++ account_move_line_report_xls/report/move_line_list_xls.xml	2013-12-18 18:05:24 +0000
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+  <data>
+
+    <record id="action_move_line_list_xls" model="ir.actions.report.xml">
+      <field name="name">Export Selected Lines</field>
+      <field name="model">account.move.line</field>
+      <field name="type">ir.actions.report.xml</field>
+      <field name="report_name">move.line.list.xls</field>
+      <field name="report_type">xls</field>
+      <field name="auto" eval="False"/>
+    </record>
+
+    <record model="ir.values" id="action_move_line_list_xls_values">
+      <field name="name">Export Selected Lines</field>
+      <field name="key2">client_action_multi</field>
+      <field name="value" eval="'ir.actions.report.xml,' +str(ref('action_move_line_list_xls'))" />
+      <field name="model">account.move.line</field>
+    </record>   
+    
+  </data>
+</openerp>

=== added directory 'account_move_line_report_xls/static'
=== added directory 'account_move_line_report_xls/static/src'
=== added directory 'account_move_line_report_xls/static/src/img'
=== added file 'account_move_line_report_xls/static/src/img/icon.png'
Binary files account_move_line_report_xls/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and account_move_line_report_xls/static/src/img/icon.png	2013-12-18 18:05:24 +0000 differ