Account - Financial Report

Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix

  1. 7.0-account_financial_report_webkit-first-special-fix
  2. Merge into 7.0
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

The parameter/fallback solution seems reasonable assuming that period parameter is not mandatory.
For me you can update the MP with that solution.

Also as the change will alter data structure the revision number of the module must be increased in MP.

I'm putting the MP in work in progress while waiting new patch.

Thanks for the work.

Regards

Nicolas

Reply

« Back to merge proposal