Code review comment for lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix

Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

No,

If you agree with the proposed approach, than I an make an MP.

Luc

www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Yannick Vaucher @ Camptocamp
Sent: vrijdag 14 maart 2014 9:48
To: <email address hidden>
Subject: Re: [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

Review: Needs Information

@Luc anything was done about this proposed change ?

> I have the impression that we move to a consensus to fix this issue by adding a parameter on the company settings with callback to current method if not defined.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
You are the owner of lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix.

« Back to merge proposal