Code review comment for lp:~ltrager/maas/global_min_hwe_kernel

I am good with default_min_hwe_kernel. That will make it consistent.
"global_" was not consistent.

On Fri, Oct 23, 2015 at 11:38 AM, Andres Rodriguez <email address hidden>
wrote:

> Review: Needs Information
>
> nevermind comment 2. I'd only like to discuss the global_min_hwe_kernel,
> or it should at least be default_min_hwe_kernel
>
> Diff comments:
>
> > === modified file 'src/maasserver/api/pxeconfig.py'
> > --- src/maasserver/api/pxeconfig.py 2015-09-08 18:41:57 +0000
> > +++ src/maasserver/api/pxeconfig.py 2015-10-23 07:37:11 +0000
> > @@ -227,6 +227,10 @@
> > # we give precedence to any kernel defined in the
> subarchitecture field
> > if subarch == "generic" and node.hwe_kernel:
> > subarch = node.hwe_kernel
> > + elif(subarch == "generic"
> > + and node.get_boot_purpose() == "commissioning"
> > + and node.min_hwe_kernel):
> > + subarch = node.min_hwe_kernel
>
> nevermind this comment, I see in the code belowe this is being addressed
>
> > else:
> > nodegroup = find_nodegroup_for_pxeconfig_request(request)
> > preseed_url =
> compose_enlistment_preseed_url(nodegroup=nodegroup)
>
>
> --
>
> https://code.launchpad.net/~ltrager/maas/global_min_hwe_kernel/+merge/275477
> You are reviewing the proposed merge of
> lp:~ltrager/maas/global_min_hwe_kernel into lp:maas.
>