Code review comment for lp:~ltrager/maas/fix_websocket_tests

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good; I can verify that this work with the latest Twisted.

Please note that after this branch lands, python3-twisted versions less than 16.0 will no longer work. (I tested it.) If you have Twisted 15.5, you'll get the following errors when running the tests in maasserver.websockets.tests:

https://paste.ubuntu.com/15175321/

review: Approve

« Back to merge proposal