Code review comment for ~ltrager/maas:lp1822173

======================================================================
ERROR: maasserver.tests.test_node_action.TestDeployAction.test_Deploy_starts_node
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Traceback (most recent call last):
  File "/run/build/maas/src/maasserver/node_action.py", line 490, in _execute
    self.node.distro_series)
  File "/run/build/maas/src/maasserver/utils/osystems.py", line 565, in validate_hwe_kernel
    raise ValidationError('%s has no kernels available.' % distro_series)
django.core.exceptions.ValidationError: ['bionic has no kernels available.']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/run/build/maas/src/maastesting/runtest.py", line 138, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/testcase.py", line 719, in _run_test_method
    return self._get_test_method()()
  File "/run/build/maas/src/maasserver/tests/test_node_action.py", line 602, in test_Deploy_starts_node
    Deploy(node, user, request).execute()
  File "/run/build/maas/src/maasserver/node_action.py", line 172, in execute
    self._execute(*args, **kwargs)
  File "/run/build/maas/src/maasserver/node_action.py", line 493, in _execute
    raise NodeActionError(e)
maasserver.exceptions.NodeActionError: bionic has no kernels available.
======================================================================
ERROR: maasserver.tests.test_node_action.TestDeployAction.test_Deploy_allocates_node_if_node_not_already_allocated
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Traceback (most recent call last):
  File "/run/build/maas/src/maasserver/node_action.py", line 490, in _execute
    self.node.distro_series)
  File "/run/build/maas/src/maasserver/utils/osystems.py", line 565, in validate_hwe_kernel
    raise ValidationError('%s has no kernels available.' % distro_series)
django.core.exceptions.ValidationError: ['bionic has no kernels available.']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/run/build/maas/src/maastesting/runtest.py", line 138, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/testcase.py", line 719, in _run_test_method
    return self._get_test_method()()
  File "/run/build/maas/src/maasserver/tests/test_node_action.py", line 836, in test_Deploy_allocates_node_if_node_not_already_allocated
    action.execute()
  File "/run/build/maas/src/maasserver/node_action.py", line 172, in execute
    self._execute(*args, **kwargs)
  File "/run/build/maas/src/maasserver/node_action.py", line 493, in _execute
    raise NodeActionError(e)
maasserver.exceptions.NodeActionError: bionic has no kernels available.

-------------------- >> begin captured logging << --------------------
maas.node: info: HUt2wpeBTOj3udHe6Sq0: Status transition from READY to ALLOCATED
maas.node: info: HUt2wpeBTOj3udHe6Sq0: allocated to user +a-OeoOSfi
--------------------- >> end captured logging << ---------------------
======================================================================
FAIL: maasserver.tests.test_node_action.TestDeployAction.test_Deploy_doesnt_set_osystem_and_series_if_os_missing
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Failed expectation: {{{MismatchError: 'ubuntu' != ''}}}
Failed expectation-1: {{{MismatchError: 'bionic' != ''}}}

Traceback (most recent call last):
  File "/run/build/maas/src/maastesting/runtest.py", line 138, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/runtest.py", line 224, in _raise_force_fail_error
    raise AssertionError("Forced Test Failure")
AssertionError: Forced Test Failure
======================================================================
FAIL: maasserver.tests.test_node_action.TestDeployAction.test_Deploy_doesnt_set_osystem_and_series_if_series_missing
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Failed expectation: {{{MismatchError: 'ubuntu' != ''}}}
Failed expectation-1: {{{MismatchError: 'bionic' != ''}}}

Traceback (most recent call last):
  File "/run/build/maas/src/maastesting/runtest.py", line 138, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/runtest.py", line 224, in _raise_force_fail_error
    raise AssertionError("Forced Test Failure")
AssertionError: Forced Test Failure
======================================================================
FAIL: maasserver.tests.test_node_action.TestDeployAction.test_Deploy_raises_NodeActionError_for_no_curtin_config
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Traceback (most recent call last):
  File "/run/build/maas/src/maastesting/runtest.py", line 138, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/testcase.py", line 719, in _run_test_method
    return self._get_test_method()()
  File "/run/build/maas/src/maasserver/tests/test_node_action.py", line 624, in test_Deploy_raises_NodeActionError_for_no_curtin_config
    "Failed to retrieve curtin config: error", str(error))
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/testcase.py", line 411, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.6.egg/testtools/testcase.py", line 498, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = 'Failed to retrieve curtin config: error'
actual = 'bionic has no kernels available.'

Ran 19215 tests in 1706.597s
FAILED (failures=5)
Makefile:275: recipe for target 'test' failed
make: *** [test] Error 2