Code review comment for ~ltrager/maas:vmfs_websocket

Revision history for this message
Björn Tillenius (bjornt) wrote :

The code itself looks good. But I'd like to see some more testing being added. First of all, for all the methods, there should be a test showing that a non-admin user can't use them.

But I also added comments for parts of the code that are still untested.

+1, assuming that you'll add those tests.

review: Approve

« Back to merge proposal