Merge ~ltrager/maas:lp1730524_2.3 into maas:2.3

[Lee Trager]

Backport of af2a66a - LP: #1730524 - Ping the metadata service before starting commissioning.

Before starting commissioning ping the metadata service, if unable exit. This
prevents the BMC password from being changed with the ephemeral environment
having no way to signal.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1730524_2.3 lp:~ltrager/maas into -b 2.3 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8478527bb88fc2a0a776588999aece2f04e7f347

review: Approve

[Alberto Donato (ack)]

+1

review: Approve

diff --git a/src/metadataserver/user_data/templates/commissioning.template b/src/metadataserver/user_data/templates/commissioning.template
index f0d49ab..bea840f 100644
--- a/src/metadataserver/user_data/templates/commissioning.template
+++ b/src/metadataserver/user_data/templates/commissioning.template
@@ -27,6 +27,10 @@ add_ipmi_config() {
 main() {
     prep_maas_api_helper
 
+    # LP:1730524 - Make sure we can signal the metadata service before updating
+    # the BMC username and password.
+    signal WORKING "Starting [maas-bmc-autodetect]" || exit 1
+
     # Install IPMI deps
     aptget install freeipmi-tools openipmi ipmitool sshpass
 
@@ -61,7 +65,7 @@ main() {
     if [ ! -z "$power_settings" ]; then
         signal \
           "--power-type=${power_type}" "--power-parameters=${power_settings}" \
-          WORKING "Finished [maas-ipmi-autodetect]"
+          WORKING "Finished [maas-bmc-autodetect]"
     fi
 
     maas-run-remote-scripts "--config=${CRED_CFG}" "${TEMP_D}"