Code review comment for ~ltrager/maas:lp1650396

Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, but I do have a question about dropping isLimitedEditingAllowed removal: it seems to be about "Deployed" status, so I think we still want to keep that. Did I miss something there (the bug only talks about allowing editing in allocated state)?

I also ain't too happy about how we create multiple test scenarios with a for loop over 3 different node statuses, but you didn't introduce this originally, so no need to fix it either, though I have to rant a bit about it :-)

review: Needs Fixing

« Back to merge proposal