Code review comment for lp:~ltrager/maas-images/rename_squashfs

Revision history for this message
Scott Moser (smoser) wrote :

2 comments:
a.) as I said above, you should tar or other wise archive the pxe files and possibly even the other files. There is no point in delivering a 'ldlinux.c32' file as a single entity. No user (maas or other) would have an interest in downloading that file, so there is no reason to make it available as a single file.

b.) The way you've added the 'src_packages' is not valid.
Products have Versions
Versions have Items
Any of those can have key/value pairs associated with them, but the values must be be strings or integers, not arbitrary data types.

so instead of
      "src_packages": [
      {
       "name": "grub-ieee1275-bin",
       "release": "yakkety",
       "version": "2.02~beta2-36ubuntu10"
      }
     ]
You should just package_name and package_version on the item if you want to maintain that information. If you have multiple package names, feel free to join them with a comma or something.

c.) Please make sure that a client (like sstream-mirror) can losslessly mirror the content you've provided.

review: Needs Fixing

« Back to merge proposal