Merge lp:~ltrager/maas-images/bootloaders_proposed into lp:maas-images

Proposed by Lee Trager
Status: Merged
Merged at revision: 394
Proposed branch: lp:~ltrager/maas-images/bootloaders_proposed
Merge into: lp:maas-images
Diff against target: 76 lines (+17/-7)
2 files modified
meph2/commands/dpkg.py (+10/-4)
meph2/commands/mimport.py (+7/-3)
To merge this branch: bzr merge lp:~ltrager/maas-images/bootloaders_proposed
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Scott Moser Pending
Review via email: mp+342893@code.launchpad.net

Commit message

Add --proposed to import command for bootloaders.

Description of the change

Output of meph2-import --proposed bootloaders.yaml bootloaders-proposed

http://162.213.35.187/bootloaders-proposed/

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'meph2/commands/dpkg.py'
2--- meph2/commands/dpkg.py 2016-08-24 20:40:23 +0000
3+++ meph2/commands/dpkg.py 2018-04-09 19:55:25 +0000
4@@ -102,7 +102,9 @@
5 return ret == 0
6
7
8-def get_package(archive, pkg_name, architecture, release=None, dest=None):
9+def get_package(
10+ archive, pkg_name, architecture, release=None, dest=None,
11+ proposed=False):
12 """Look through the archives for package metadata. If a dest is given
13 download the package.
14
15@@ -112,7 +114,10 @@
16 release = get_distro_release() if release is None else release
17 package = None
18 # Find the latest version of the package
19- for dist in ('%s-updates' % release, '%s-security' % release, release):
20+ dists = ('%s-updates' % release, '%s-security' % release, release)
21+ if proposed:
22+ dists = ('%s-proposed' % release,) + dists
23+ for dist in dists:
24 base_url = '%s/dists/%s' % (archive, dist)
25 packages = get_packages(base_url, architecture, pkg_name)
26 if pkg_name in packages:
27@@ -218,11 +223,12 @@
28
29 def extract_files_from_packages(
30 archive, packages, architecture, files, release, target, path,
31- grub_format=None, grub_config=None, grub_output=None):
32+ grub_format=None, grub_config=None, grub_output=None, proposed=False):
33 tmp = tempfile.mkdtemp(prefix='maas-images-')
34 src_packages = []
35 for package in packages:
36- package = get_package(archive, package, architecture, release, tmp)
37+ package = get_package(
38+ archive, package, architecture, release, tmp, proposed=proposed)
39 pkg_path = os.path.join(tmp, os.path.basename(package['Filename']))
40 if pkg_path is None:
41 sys.stderr.write('%s not found in archives!' % package)
42
43=== modified file 'meph2/commands/mimport.py'
44--- meph2/commands/mimport.py 2017-05-02 07:31:59 +0000
45+++ meph2/commands/mimport.py 2018-04-09 19:55:25 +0000
46@@ -97,8 +97,9 @@
47 src_packages = {}
48 for package in firmware_platform['packages']:
49 package_info = get_package(
50- firmware_platform['archive'], package,
51- firmware_platform['arch'], firmware_platform['release'])
52+ archive=firmware_platform['archive'], pkg_name=package,
53+ architecture=firmware_platform['arch'],
54+ release=firmware_platform['release'], proposed=args.proposed)
55 # Some source packages include the package version in the source
56 # name. Only take the name, not the version.
57 src_package_name = package_info['Source'].split(' ')[0]
58@@ -167,7 +168,7 @@
59 firmware_platform['arch'], firmware_platform['files'],
60 firmware_platform['release'], args.target, path, grub_format,
61 firmware_platform.get('grub_config'),
62- firmware_platform.get('grub_output'))
63+ firmware_platform.get('grub_output'), args.proposed)
64 product_tree['products'][product_id]['versions'][version] = {
65 'items': items
66 }
67@@ -308,6 +309,9 @@
68 args = [args]
69 parser.add_argument(*args, **kwargs)
70 parser.set_defaults(action=main_import)
71+ parser.add_argument(
72+ '--proposed', help='Pull bootloaders from proposed',
73+ action='store_true', default=False)
74
75 args = parser.parse_args()
76 if not getattr(args, 'action', None):

Subscribers

People subscribed via source and target branches