Code review comment for lp:~ltrager/curtin/lp1640519

Revision history for this message
Lee Trager (ltrager) wrote :

Thanks for the updated review. On deployments I think its better for Curtin/MAAS to only install packages in the target install that are really needed. As such sticking with using flash-kernel to detect if additional dependencies are needed seems to be the better path. I've updated the MP to ask flash-kernel what packages are needed for the target machine instead of just assuming that u-boot-tools are always needed. Flash kernel doesn't list itself as a needed dependency so that is now also installed in the target system.

The ephemeral environment that MAAS uses is now the image that is being deployed. That image is the one that is published at cloud-images.ubuntu.com. My understanding is that we don't want flash-kernel in that image which is why Curtin has to install it in the ephemeral environment.

« Back to merge proposal