Code review comment for lp:~lotheac/lightdm/utmpx

Revision history for this message
Lauri Tirkkonen (lotheac) wrote :

> 58 + if (!is_greeter) {
> 59 + /* Open the session */
> 60 + result = pam_open_session (pam_handle, 0);
> You should still open a PAM session for the greeter, why not?

Because if we don't, we can stack pam_lastlog as a session module in order to record user sessions to wtmp and lastlog. I could comment that, though.

> 73 - /* Wait for the command to complete (blocks) */
> You seem to have accidentally removed a comment :(

It's actually just been moved closer to the wait call :) line 101 in the diff

I'll try to get around to fixing the rest later today.

« Back to merge proposal