Merge ~lorn-potter/snappy-hwe-snaps/+git/sensehat-snap:leds into ~snappy-hwe-team/snappy-hwe-snaps/+git/sensehat:master

Proposed by Lorn Potter
Status: Merged
Approved by: Jim Hodapp
Approved revision: 3a51421a967d3f4642322e73b4f82b2ac2091831
Merged at revision: 3a51421a967d3f4642322e73b4f82b2ac2091831
Proposed branch: ~lorn-potter/snappy-hwe-snaps/+git/sensehat-snap:leds
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/sensehat:master
Diff against target: 75 lines (+26/-2)
3 files modified
README (+8/-0)
report.sh (+8/-0)
snapcraft.yaml (+10/-2)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+302965@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

See comments inline. Over all looks good though.

review: Needs Fixing
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README b/README
index 0c35eeb..012cffc 100644
--- a/README
+++ b/README
@@ -27,3 +27,11 @@ https://github.com/lpotter/sensors-examples.git
2727
28to see sensor data, run the report.sh script, such as:28to see sensor data, run the report.sh script, such as:
29sudo /snap/bin/sensehat.report compass29sudo /snap/bin/sensehat.report compass
30
31To run the compass demo, first run
32sensehat.RTIMULibCal
33and calibrate the magnetometer and accelerometer.
34Then you can run sensehat.report example
35
36Hold the rpi with the power adapter side pointing down.
37
diff --git a/report.sh b/report.sh
index 268f2a8..75d41c4 100755
--- a/report.sh
+++ b/report.sh
@@ -25,6 +25,10 @@ export QT_PLUGIN_PATH=$SNAP/usr/lib/$ARCH/qt5/plugins
25export XDG_CONFIG_DIRS=$SNAP/etc/xdg25export XDG_CONFIG_DIRS=$SNAP/etc/xdg
26export SENSEHAT_CONFIG_DIR=$SNAP_USER_DATA26export SENSEHAT_CONFIG_DIR=$SNAP_USER_DATA
2727
28if [ ! -e "$HOME/RTIMULib.ini" ]
29then
30 cp $SNAP/etc/RTIMULib.ini $HOME/RTIMULib.ini
31fi
2832
29while [[ $# -gt 0 ]]33while [[ $# -gt 0 ]]
30do34do
@@ -62,6 +66,10 @@ case $app in
62 echo "pressure"66 echo "pressure"
63 exec "$SNAP/usr/bin/show_pressure"67 exec "$SNAP/usr/bin/show_pressure"
64 ;;68 ;;
69 -e | example)
70 echo "example"
71 exec "$SNAP/usr/bin/sensehat-compass"
72 ;;
65 --default)73 --default)
66 ;;74 ;;
67 *)75 *)
diff --git a/snapcraft.yaml b/snapcraft.yaml
index eaa1064..cde3ea5 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -7,14 +7,15 @@ description: |
7 Source is available at:7 Source is available at:
8 https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/sensehat8 https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/sensehat
99
10
11apps:10apps:
12 RTIMULibDrive11:11 RTIMULibDrive11:
13 command: bin/RTIMULibDrive1112 command: bin/RTIMULibDrive11
14 RTIMULibCal:13 RTIMULibCal:
15 command: bin/RTIMULibCal14 command: bin/RTIMULibCal $HOME/snap/sensehat/current/RTIMULib
16 report:15 report:
17 command: bin/report.sh16 command: bin/report.sh
17 sensehat-compass:
18 command: usr/bin/sensehat-compass
1819
19parts:20parts:
20 rtimulib:21 rtimulib:
@@ -44,3 +45,10 @@ parts:
44 plugin: qmake45 plugin: qmake
45 qt-version: qt546 qt-version: qt5
46 source: https://github.com/lpotter/sensors-examples.git47 source: https://github.com/lpotter/sensors-examples.git
48 sensehat-compass:
49 plugin: qmake
50 qt-version: qt5
51 source: https://github.com/lpotter/sensehat-compass.git
52 stage-packages:
53 - libpng12-0
54 - libfreetype6

Subscribers

People subscribed via source and target branches

to all changes: