Code review comment for lp:~lore-mattei/unity/fix-bug-891818

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> > This is fine, but you'd also need to add after:
> >
> > self.addCleanup(self.dash.ensure_hidden)
> >
> > This will ensure that if the test fails, the dash is hidden anyway.
>
> I think the self.dash.ensure_hidden() call in tearDown() will ensure that.
> Isn't it called even in case of fail?

Yes, sure. The version I checked, maybe was missing it.
Sorry.

review: Approve

« Back to merge proposal