Code review comment for lp:~lore-mattei/unity/fix-bug-891818

Revision history for this message
Lorenzo Mattei (lore-mattei) wrote :

> This is fine, but you'd also need to add after:
>
> self.addCleanup(self.dash.ensure_hidden)
>
> This will ensure that if the test fails, the dash is hidden anyway.

I think the self.dash.ensure_hidden() call in tearDown() will ensure that. Isn't it called even in case of fail?

> Maybe, even including a small sleep after the alt+f4 press, could avoid false-
> negatives.
Ok.

« Back to merge proposal