Merge lp:~lool/ubuntu-download-manager/udm-no-debug into lp:ubuntu-download-manager

[Loïc Minier]

Always honor UBUNTU_DOWNLOADER_DEBUG; we should consider switching release builds to -UDEBUG, but this is too intrusive right now; LP: #1240656.

Always honor UBUNTU_DOWNLOADER_DEBUG; we should consider switching release builds to -UDEBUG, but this is too intrusive right now; LP: #1240656.

[Roberto Alsina (ralsina)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

[Loïc Minier (lool)]

Tested with click downloads; almost too quiet now; just logs:
2013-10-17 00:41:19,288 - WARNING - QObject::connect: No such signal SystemNetworkInfo::onlineStateChange(bool)
which is probably worth fixing too

We should tweak debug/trace messages

=== modified file 'libubuntudownloadmanager/download_daemon.cpp'
--- libubuntudownloadmanager/download_daemon.cpp	2013-09-20 15:54:50 +0000
+++ libubuntudownloadmanager/download_daemon.cpp	2013-10-16 23:53:28 +0000
@@ -158,12 +158,8 @@
 
         // set logging
         Logger::setupLogging();
-#ifdef DEBUG
-        Logger::setLogLevel(QtDebugMsg);
-#else
         if (qgetenv("UBUNTU_DOWNLOADER_DEBUG") != "")
             Logger::setLogLevel(QtDebugMsg);
-#endif
     }
 
  private: