disable debug logging by default

Bug #1240656 reported by Jean-Baptiste Lallement
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-download-manager (Ubuntu)
Fix Released
Critical
Unassigned
Saucy
Fix Released
Undecided
Unassigned

Bug Description

[Test Case]

1. Start up a Ubuntu Touch device with the latest ubuntu-download-manager
2. Start the Update Manager
3. Check /home/phablet/.cache/ubuntu-download-manager/ubuntu-download-manager
   -> Make sure there is no unneeded debugging output, only WARNINGS and ERRORS should be present, no DEBUG messages

[Regression Potential]

Basically none, as we only modify the debugging flags. Debugging output is not required.

Original description:

By default u-d-m logs message with level DEBUG. This is far too verbose and an upgrade on mako from build 92 to build 99 generated 2.2MB of log messages.
Logging level should be set to info by default.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: ubuntu-download-manager 0.2+13.10.20131016.1-0ubuntu1
Uname: Linux 3.4.0-3-mako armv7l
ApportVersion: 2.12.5-0ubuntu1
Architecture: armhf
Date: Wed Oct 16 19:04:40 2013
InstallationDate: Installed on 2013-10-10 (6 days ago)
InstallationMedia: Ubuntu Saucy Salamander (development branch) - armhf (20131010.2)
MarkForUpload: True
ProcEnviron:
 TERM=linux
 PATH=(custom, no user)
SourcePackage: ubuntu-download-manager
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
summary: - disabled debug logging by default
+ disable debug logging by default
Loïc Minier (lool)
Changed in ubuntu-download-manager (Ubuntu):
importance: Undecided → Critical
Revision history for this message
Loïc Minier (lool) wrote :

Note: Critical because this triggers lots of data to syslog for small system updates and for clicks, it also seems to affect download speed for both, there is some garbage logged in syslog, and we also lack any kind of rotation of either logs.

Changed in ubuntu-download-manager (Ubuntu):
status: New → Triaged
Changed in ubuntu-download-manager (Ubuntu):
status: Triaged → In Progress
description: updated
Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Hello Jean-Baptiste, or anyone else affected,

Accepted ubuntu-download-manager into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ubuntu-download-manager/0.2+13.10.20131104-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-download-manager (Ubuntu Saucy):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Loïc Minier (lool) wrote :

Just tested the binaries in proposed by:
* installing latest saucy-proposed image (101)
* adb shell-ing into device
* remounting rw
* installing debs by hand
* remounting ro
* rebooting

Then tested by:
* installing a Click package from appstore; confirmed that /home/phablet/.cache/ubuntu-download-manager/ubuntu-download-manager/ubuntu-download-manager.log had no debug log; in fact it only had a known broken signal connection:
2013-11-26 16:10:28,564 - WARNING - QObject::connect: No such signal SystemNetworkInfo::onlineStateChange(bool)
* upgrading to trusty (system-image-cli -c trusty-proposed -b 0); confirmed that syslog had no debug output; however note that it had no output at all (not even the above WARNING), which is probably due to a known bug with syslog handling of warning messages in download-manager; I ended up on trusty-proposed (31)

(IOW, this all worked fine)

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-download-manager - 0.2+13.10.20131104-0ubuntu1

---------------
ubuntu-download-manager (0.2+13.10.20131104-0ubuntu1) saucy; urgency=low

  [ Loïc Minier ]
  * Always honor UBUNTU_DOWNLOADER_DEBUG; we should consider switching
    release builds to -UDEBUG, but this is too intrusive right now; LP:
    #1240656. (LP: #1240656)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 151
 -- Ubuntu daily release <email address hidden> Mon, 04 Nov 2013 11:19:32 +0000

Changed in ubuntu-download-manager (Ubuntu Saucy):
status: Fix Committed → Fix Released
Revision history for this message
Stéphane Graber (stgraber) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.8 KiB)

This bug was fixed in the package ubuntu-download-manager - 0.3+14.04.20131219-0ubuntu1

---------------
ubuntu-download-manager (0.3+14.04.20131219-0ubuntu1) trusty; urgency=low

  [ Loïc Minier ]
  * Always honor UBUNTU_DOWNLOADER_DEBUG; we should consider switching
    release builds to -UDEBUG, but this is too intrusive right now; LP:
    #1240656. (LP: #1240656)

  [ Michael McCracken ]
  * change command for 'make check' to work when not in tree (LP:
    #1249470). (LP: #1249470)

  [ Manuel de la Pena ]
  * Fix a number of logging problems found when we went to production.
    (LP: #1240656, #1241009, #1241005, #1240967)
  * Move download ids to be strings, that way applications have more
    predictable ways to connect to the current downloads. At the moment
    only not confined apps can use predictable ids. (LP: #1234965)
  * Group all system related files under the same dir.
  * Moved all downloads related to the same directory.
  * Renamed the DownloadDaemon to Daemon to remove the redundancy in the
    name.
  * Rename DownloadFactory to Factory to remove the redundancy in the
    name.
  * Rename the DownloaderQueue to Queue to remove the redundancy in the
    name.
  * Rename DownloadManager to Manager to remove the name redundancy.
  * Rename SIngleDownlaod to FileDownload so that it makes more sense.
  * Start using namespaces planning ahead when we have a client library.
  * Add the use of a new namespace for system realted classes.
  * Sort the files under the test project so that working on it is
    simpler.
  * Add documentation about the state machine to be used for the
    downloads and its initial skeleton.
  * Ensure that finished is raised when the group download is empty.
    (LP: #1245597)
  * Allow to pass the path of the service to be started so that it is
    easier to test. (LP: #1195657)
  * Create the download state machine and add the states defined in the
    docs diagram.
  * Provide a processing signal for when the downloading is done and a
    process is being executed. (LP: #1248770)
  * Provide setters and getters for the daemon command line args. Added
    self signed ssl certs for testing purposes. (LP: #1249336)
  * Add the header transitions. There is not yet nothing done because
    parsing the header info for the attachment name is harder than
    expected.
  * Ensure that group downloads do not allow two same local paths in the
    same group. (LP: #1250181)
  * Remove all the checks against NULL before calling delete. (LP:
    #1250409)
  * Remove the not needed pimpl pattern from the DBusConnection class.
    (LP: #1251008)
  * Remove the pimpl patter from the Application class. (LP: #1251003)
  * Add the transitions for the init state.
  * Added the downloading state transitions.
  * Remove the pimpl patter from the system network info. Because pimpl
    is out we can use the new signal connection. (LP: #1250946)
  * Remove the use of the pimpl pattern in the factory object because is
    not needed. Fix some issues with the tests after the change. (LP:
    #1250927)
  * Added downloading not connected state transitions.
  * Remove the pimpl pattern from the ProcessFactory. (LP: #1251269)
  ...

Read more...

Changed in ubuntu-download-manager (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.