Code review comment for lp:~lool/ubuntu-dev-tools/fix-non-ascii-name
Revision history for this message
| Loïc Minier (lool) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
(missed your review for some reason; sorry)
Good catch; I've pushed r1391 to default to utf-8 in the config when locale doesn't specify an encoding and r1392 to convert the string from utf-8 into the current locale in the test.
I didn't want to require a specific locale to run the tests or add heavy build-deps; the only requirement now is that the current locale's encoding allows representing "Jöe Déveloper"; alternatively we could set the locale in the test but that seemed more invasive.