Merge lp:~lool/ubuntu-app-launch/lp-1227632 into lp:ubuntu-app-launch/13.10

Proposed by Loïc Minier
Status: Merged
Approved by: Ted Gould
Approved revision: 58
Merged at revision: 58
Proposed branch: lp:~lool/ubuntu-app-launch/lp-1227632
Merge into: lp:ubuntu-app-launch/13.10
Diff against target: 12 lines (+1/-1)
1 file modified
helpers.c (+1/-1)
To merge this branch: bzr merge lp:~lool/ubuntu-app-launch/lp-1227632
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+186526@code.launchpad.net

Commit message

Fix LP #1227632 by directly joining the components of the Exec line split on % instead of joining them with spaces.

Description of the change

Try to fix LP #1227632 by directly joining the components of the Exec line split on % instead of joining them with spaces.

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

Wanted to add a test case, but there was none setup; happy to copy an existing test setup from another CMake project to apply it here.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Works here, thanks for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'helpers.c'
--- helpers.c 2013-09-18 21:13:34 +0000
+++ helpers.c 2013-09-19 13:08:08 +0000
@@ -443,7 +443,7 @@
443 }443 }
444 }444 }
445445
446 gchar * output = g_strjoinv(" ", (gchar **)outarray->data);446 gchar * output = g_strjoinv(NULL, (gchar **)outarray->data);
447 g_array_free(outarray, TRUE);447 g_array_free(outarray, TRUE);
448448
449 g_free(single_uri);449 g_free(single_uri);

Subscribers

People subscribed via source and target branches