Code review comment for lp:~lool/linaro-image-tools/mkfs-uuid

Revision history for this message
James Westby (james-w) wrote :

On Wed, 26 Jan 2011 12:29:09 -0000, Loïc Minier <email address hidden> wrote:
> But ignoring the return value then -- ok; I guess otherwise I would
> have to introduce a new Popen mock which supports returning some
> pre-defined output in communicate().

I didn't realise that was missing. I assumed that you would be doing
that.

I don't think it's super critical, but would be nice to have.

Thanks,

James

« Back to merge proposal