Code review comment for lp:~lool/linaro-image-tools/mkfs-uuid

Revision history for this message
James Westby (james-w) wrote :

Looks good so far.

For a get_uuid() test I would use the subprocess mocking again to ensure that
it calls the correct thing. It would be testing that at multiple layers, but
I think that's just the price we have to pay here.

Thanks,

James

« Back to merge proposal