Code review comment for lp:~lool/launchpad-work-items-tracker/jira-support

Revision history for this message
Milo Casagrande (milo) wrote :

Hello Loic,

thanks for working on this.

On Tue, Jun 26, 2012 at 5:14 PM, Loïc Minier <email address hidden> wrote:
> Probably fixing the latter requires some DB changes; I'm not sure what rules we operate on for these though, e.g. how does one deploy the schema update?

WRT this point, I have to collect info too: our knowledge base does not report anything for this situation, and will have to ask Danilo and maybe IS too.

From a rapid PEP8 run, I get these two errors:

collect_jira:5:15: E401 multiple imports on one line
all-projects:77:80: E501 line too long (94 characters)

Apart from those, everything looks good. In case, fix during the merge.

review: Approve

« Back to merge proposal