Merge lp:~longbow/percona-xtrabackup/fix_687544 into lp:percona-xtrabackup/2.0
Proposed by
Valentine Gostev
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 341 |
Proposed branch: | lp:~longbow/percona-xtrabackup/fix_687544 |
Merge into: | lp:percona-xtrabackup/2.0 |
Diff against target: |
46 lines (+6/-7) 1 file modified
innobackupex (+6/-7) |
To merge this branch: | bzr merge lp:~longbow/percona-xtrabackup/fix_687544 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+83901@code.launchpad.net |
This proposal supersedes a proposal from 2011-11-22.
Description of the change
Added fix for bug 687544.
Merge form 1.6 - lp:~longbow/percona-xtrabackup/fix687544-1.6
To post a comment you must log in.
- the bug is targeted to 1.6, so it should be fixed in 1.6 first,
then merged to 1.7 with a separate MP
- :seekable is not being used, so why is it being imported
into the global namespace?
- there's no need to get tmpdir explicitly, File::Temp uses it by
default according to its documentation
- there's no need to specify the template explicitly, we don't care
about the name, let File::Temp choose it
- we don't care about the suffix either
- File::Temp->new() returns a file handle, but its result is assigned
to a variable with a file name?
Even though the returned object is evaluated as a file name when
used as a string, I think we should play safe and use something
like this:
my $mysql_ stderr_ handle = File::Temp->new(); stderr_ handle- >filename( );
my $mysql_stderr = $mysql_
- note that $mysql_stderr and $mysql_stdout are reassigned in
init(). I think we should remove those reassignments, but please
double check.
- how about a test case? (it would immediately reveal the last issue,
for example)